TononixOS/ubports_kernel_google_msm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

usb: gadget: mbim: Remove duplicate unlock

Browse Source 
Function mbim_notify should be called inside locked context,
add missing lock.
Also remove duplicate lock initialization.

CRs-Fixed: 366821
Change-Id: I3431b20e831c807da7fa74cc40aa098f43330a9b
Signed-off-by: Anna Perel <aperel@codeaurora.org>
This commit is contained in:
Anna Perel
2012-06-13 17:17:24 +03:00
committed by Stephen Boyd
parent a4f0e82e73
commit 0b16f159e4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/f_mbim.c
View File

@@ -795,6 +795,7 @@ static void mbim_notify_complete(struct usb_ep *ep, struct usb_request *req)
spin_unlock(&mbim->lock); spin_unlock(&mbim->lock);
mbim_clear_queues(mbim); mbim_clear_queues(mbim);
mbim_reset_function_queue(mbim); mbim_reset_function_queue(mbim);
spin_lock(&mbim->lock);
break; break;
default: default:
pr_err("Unknown event %02x --> %d\n", pr_err("Unknown event %02x --> %d\n",
@@ -1450,8 +1451,6 @@ int mbim_bind_config(struct usb_configuration *c, unsigned portno)
mbim->cdev = c->cdev; mbim->cdev = c->cdev;
spin_lock_init(&mbim->lock);
mbim_reset_values(mbim); mbim_reset_values(mbim);
mbim->function.name = "usb_mbim"; mbim->function.name = "usb_mbim";
@@ -1615,6 +1614,7 @@ mbim_write(struct file *fp, const char __user *buf, size_t count, loff_t *pos)
pr_debug("Exit(%d)", count); pr_debug("Exit(%d)", count);
return count; return count;
} }
static int mbim_open(struct inode *ip, struct file *fp) static int mbim_open(struct inode *ip, struct file *fp)