TononixOS/ubports_kernel_google_msm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "checkpatch: Add warning for blank lines in header"

Browse Source 
This reverts commit 8212698c653945d0fd0783829822917bf13a5aab.
The original commit incorrectly prevents the following:
  - Commit messages which cite other commit messages, which
    are commonly used for attribution;
  - Any use of checkpatch which doesn't contain a full mail header,
    such as 'show <ref> | checkpatch.pl -'

Change-Id: I681a97913432d05bf66290cf74972aaa4e03fe5d
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit c73e32b4a1a59e3a33e9c8975ab08b5475d30f3e)
This commit is contained in:
Gregory Bean
2010-08-07 07:34:23 -07:00
committed by Stephen Boyd
parent dc4e47c544
commit 45da08a85b
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
scripts/checkpatch.pl
View File

@@ -1381,7 +1381,6 @@ sub process {
my $stashrawline=""; my $stashrawline="";
my $subjectline=""; my $subjectline="";
my $sublinenr=""; my $sublinenr="";
my $blankline_flag=0;
my $length; my $length;
my $indent; my $indent;
@@ -1718,7 +1717,6 @@ sub process {
if ($line =~ /^\s*signed-off-by:.*(quicinc|qualcomm)\.com/i) { if ($line =~ /^\s*signed-off-by:.*(quicinc|qualcomm)\.com/i) {
WARN("invalid Signed-off-by identity\n" . $line ); WARN("invalid Signed-off-by identity\n" . $line );
} }
$blankline_flag = 1;
} }
#check the patch for invalid author credentials #check the patch for invalid author credentials
@@ -1726,13 +1724,6 @@ sub process {
WARN("invalid author identity\n" . $line ); WARN("invalid author identity\n" . $line );
} }
#check the patch for blank lines in the header
if($line =~ /^\s*$/ && $blankline_flag == 1) {
WARN("Blank lines should not appear in the header once signed off\n");
} elsif($line =~ /^---$/) {
$blankline_flag = 0;
}
# Check for wrappage within a valid hunk of the file # Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("CORRUPTED_PATCH", ERROR("CORRUPTED_PATCH",