From 5bc97df95b426b3338c0a70c4e2b973dba27794a Mon Sep 17 00:00:00 2001 From: Gregory Bean Date: Thu, 17 Mar 2011 14:18:20 -0700 Subject: [PATCH] checkpatch: forbid filesystem accesses from within the kernel. Use of the sys_open/close/read/write system calls from within kernel code is inappropriate, and now triggers errors. Change-Id: I98e20513c257d0664684b7144585853f617d771a Signed-off-by: Gregory Bean (cherry picked from commit ee62f2afcac1bcb180b2f0dddf2c8f5cda54bc5b) --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 166552fd29e..9d8b66f6a74 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3219,6 +3219,12 @@ sub process { "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); } +# sys_open/read/write/close are not allowed in the kernel + if ($line =~ /\b(sys_(?:open|read|write|close))\b/) { + ERROR("$1 is inappropriate in kernel code.\n" . + $herecurr); + } + # warn about #if 0 if ($line =~ /^.\s*\#\s*if\s+0\b/) { WARN("if this code is redundant consider removing it\n"