diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c index 01a1c9f8a38..d529ea42ce1 100644 --- a/drivers/input/keyboard/pmic8xxx-keypad.c +++ b/drivers/input/keyboard/pmic8xxx-keypad.c @@ -116,6 +116,9 @@ static int pmic8xxx_kp_write_u8(struct pmic8xxx_kp *kp, int rc; rc = pm8xxx_writeb(kp->dev->parent, reg, data); + if (rc < 0) + dev_warn(kp->dev, "Error writing pmic8xxx: %X - ret %X\n", + reg, rc); return rc; } @@ -125,6 +128,10 @@ static int pmic8xxx_kp_read(struct pmic8xxx_kp *kp, int rc; rc = pm8xxx_read_buf(kp->dev->parent, reg, data, num_bytes); + if (rc < 0) + dev_warn(kp->dev, "Error reading pmic8xxx: %X - ret %X\n", + reg, rc); + return rc; } @@ -134,6 +141,9 @@ static int pmic8xxx_kp_read_u8(struct pmic8xxx_kp *kp, int rc; rc = pmic8xxx_kp_read(kp, data, reg, 1); + if (rc < 0) + dev_warn(kp->dev, "Error reading pmic8xxx: %X - ret %X\n", + reg, rc); return rc; } @@ -463,7 +473,7 @@ static int __devinit pmic8xxx_kp_config_gpio(int gpio_start, int num_gpios, __func__, gpio_start + i, rc); return rc; } - } + } return 0; } @@ -532,7 +542,7 @@ static int __devinit pmic8xxx_kp_probe(struct platform_device *pdev) .output_buffer = PM_GPIO_OUT_BUF_OPEN_DRAIN, .output_value = 0, .pull = PM_GPIO_PULL_NO, - .vin_sel = PM_GPIO_VIN_S3, + .vin_sel = PM_GPIO_VIN_S4, .out_strength = PM_GPIO_STRENGTH_LOW, .function = PM_GPIO_FUNC_1, .inv_int_pol = 1, @@ -541,7 +551,7 @@ static int __devinit pmic8xxx_kp_probe(struct platform_device *pdev) struct pm_gpio kypd_sns = { .direction = PM_GPIO_DIR_IN, .pull = PM_GPIO_PULL_UP_31P5, - .vin_sel = PM_GPIO_VIN_S3, + .vin_sel = PM_GPIO_VIN_S4, .out_strength = PM_GPIO_STRENGTH_NO, .function = PM_GPIO_FUNC_NORMAL, .inv_int_pol = 1,