Sweep away N/A fw_version dustbunnies from the .get_drvinfo routine of a number of drivers
Per discussion with Ben Hutchings and David Miller, go through and remove assignments of "N/A" to fw_version in various drivers' .get_drvinfo routines. While there clean-up some use of bare constants and such. Signed-off-by: Rick Jones <rick.jones2@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
4e3fd7a06d
commit
84b4050111
@@ -2378,7 +2378,6 @@ static void e100_get_drvinfo(struct net_device *netdev,
|
||||
struct nic *nic = netdev_priv(netdev);
|
||||
strlcpy(info->driver, DRV_NAME, sizeof(info->driver));
|
||||
strlcpy(info->version, DRV_VERSION, sizeof(info->version));
|
||||
strlcpy(info->fw_version, "N/A", sizeof(info->fw_version));
|
||||
strlcpy(info->bus_info, pci_name(nic->pdev),
|
||||
sizeof(info->bus_info));
|
||||
}
|
||||
|
||||
@@ -521,7 +521,6 @@ static void e1000_get_drvinfo(struct net_device *netdev,
|
||||
strlcpy(drvinfo->version, e1000_driver_version,
|
||||
sizeof(drvinfo->version));
|
||||
|
||||
strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
|
||||
strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
|
||||
sizeof(drvinfo->bus_info));
|
||||
drvinfo->regdump_len = e1000_get_regs_len(netdev);
|
||||
|
||||
@@ -195,8 +195,6 @@ static void igbvf_get_drvinfo(struct net_device *netdev,
|
||||
strlcpy(drvinfo->driver, igbvf_driver_name, sizeof(drvinfo->driver));
|
||||
strlcpy(drvinfo->version, igbvf_driver_version,
|
||||
sizeof(drvinfo->version));
|
||||
strlcpy(drvinfo->fw_version, "N/A",
|
||||
sizeof(drvinfo->fw_version));
|
||||
strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
|
||||
sizeof(drvinfo->bus_info));
|
||||
drvinfo->regdump_len = igbvf_get_regs_len(netdev);
|
||||
|
||||
@@ -477,7 +477,6 @@ ixgb_get_drvinfo(struct net_device *netdev,
|
||||
sizeof(drvinfo->driver));
|
||||
strlcpy(drvinfo->version, ixgb_driver_version,
|
||||
sizeof(drvinfo->version));
|
||||
strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
|
||||
strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
|
||||
sizeof(drvinfo->bus_info));
|
||||
drvinfo->n_stats = IXGB_STATS_LEN;
|
||||
|
||||
@@ -267,11 +267,11 @@ static void ixgbevf_get_drvinfo(struct net_device *netdev,
|
||||
{
|
||||
struct ixgbevf_adapter *adapter = netdev_priv(netdev);
|
||||
|
||||
strlcpy(drvinfo->driver, ixgbevf_driver_name, 32);
|
||||
strlcpy(drvinfo->version, ixgbevf_driver_version, 32);
|
||||
|
||||
strlcpy(drvinfo->fw_version, "N/A", 4);
|
||||
strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), 32);
|
||||
strlcpy(drvinfo->driver, ixgbevf_driver_name, sizeof(drvinfo->driver));
|
||||
strlcpy(drvinfo->version, ixgbevf_driver_version,
|
||||
sizeof(drvinfo->version));
|
||||
strlcpy(drvinfo->bus_info, pci_name(adapter->pdev),
|
||||
sizeof(drvinfo->bus_info));
|
||||
}
|
||||
|
||||
static void ixgbevf_get_ringparam(struct net_device *netdev,
|
||||
|
||||
Reference in New Issue
Block a user