TononixOS/ubports_kernel_google_msm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: xhci: Use GFP_ATOMIC under spin_lock

Browse Source 
coccinelle check scripts/coccinelle/locks/call_kern.cocci found that
in drivers/usb/host/xhci.c an allocation with GFP_KERNEL is done
with locks held:

xhci_resume
  spin_lock_irq(xhci->lock)
    xhci_setup_msix
      kmalloc(GFP_KERNEL)

Change it to GFP_ATOMIC.

Signed-off-by: David Sterba <dsterba@suse.cz>
CC: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
David Sterba
2010-11-02 23:47:18 +01:00
committed by Greg Kroah-Hartman
parent 4b4cd731b0
commit ef821ae70f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/host/xhci.c
View File

@@ -240,7 +240,7 @@ static int xhci_setup_msix(struct xhci_hcd *xhci)
xhci->msix_entries = xhci->msix_entries =
kmalloc((sizeof(struct msix_entry))*xhci->msix_count, kmalloc((sizeof(struct msix_entry))*xhci->msix_count,
GFP_KERNEL); GFP_ATOMIC);
if (!xhci->msix_entries) { if (!xhci->msix_entries) {
xhci_err(xhci, "Failed to allocate MSI-X entries\n"); xhci_err(xhci, "Failed to allocate MSI-X entries\n");
return -ENOMEM; return -ENOMEM;