Linus Torvalds
c32da02342
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
...
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (56 commits)
doc: fix typo in comment explaining rb_tree usage
Remove fs/ntfs/ChangeLog
doc: fix console doc typo
doc: cpuset: Update the cpuset flag file
Fix of spelling in arch/sparc/kernel/leon_kernel.c no longer needed
Remove drivers/parport/ChangeLog
Remove drivers/char/ChangeLog
doc: typo - Table 1-2 should refer to "status", not "statm"
tree-wide: fix typos "ass?o[sc]iac?te" -> "associate" in comments
No need to patch AMD-provided drivers/gpu/drm/radeon/atombios.h
devres/irq: Fix devm_irq_match comment
Remove reference to kthread_create_on_cpu
tree-wide: Assorted spelling fixes
tree-wide: fix 'lenght' typo in comments and code
drm/kms: fix spelling in error message
doc: capitalization and other minor fixes in pnp doc
devres: typo fix s/dev/devm/
Remove redundant trailing semicolons from macros
fix typo "definetly" -> "definitely" in comment
tree-wide: s/widht/width/g typo in comments
...
Fix trivial conflict in Documentation/laptops/00-INDEX
2010-03-12 16:04:50 -08:00
Joe Perches
724ee626f3
drivers/block/floppy.c: remove unnecessary casting in fd_ioctl
...
Convert outparam to const void *.
Cast outparam to const char * for strlen().
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
0aad92cfea
drivers/block/floppy.c: remove misleading, used once FD_IOCTL_ALLOWED macro
...
Just code the test directly
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
712e1de43e
drivers/block/floppy.c: remove obfuscating CODE2SIZE macro
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
ded2863d09
drivers/block/floppy.c: add __func__ to debugt
...
Make debugt messages a little neater.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
7f2527174a
drivers/block/floppy.c: convert raw_cmd_copyin from while(1) to label: goto
...
Reduces indent.
Makes a bit more readable and intelligible.
Return value now at bottom of function.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
ce2f11fe78
drivers/block/floppy.c: remove some unnecessary casting
...
Remove char/void __user * use.
Remove kmalloc cast.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
1ebddd85a6
drivers/block/floppy.c: use %pf in logging messages
...
Print the function name not the pointer address where useful and possible
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
275176bc2a
drivers/block/floppy.c: use __func__ where appropriate
...
Add and use __func__ to is_alive.
Use __func__ in some DPRINTs.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
891eda80a5
drivers/block/floppy.c: DPRINT neatening
...
Move DPRINT macro definition above 1st use Consolidate a format string
(>80 columns) Add a newline to an unterminated message Comment neatened
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
1a23d13335
drivers/block/floppy.c: remove #define FLOPPY_SANITY_CHECK
...
The code could not be compiled without the #define, so just remove it and
the #ifdef/#endif lines.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
73507e6cd8
drivers/block/floppy.c: remove unnecessary argument from [__]reschedule_timeout
...
Prior to patch "drivers/block/floppy.c: Use pr_<level>" only
reschedule_timeout(,"request done"...) printed a numeric value after a
reschedule_timeout event message.
Restore that behavior and remove the now unnecessary argument.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
0da3132f90
drivers/block/floppy.c: unclutter redo_fd_request logic
...
Change for(;;) with continue; to label: goto label
Reduces indentation and adds a bit of clarity.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:31 -08:00
Joe Perches
416d8d2888
drivers/block/floppy.c: remove REPEAT macro
...
Macros with hidden flow changes aren't nice.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
15b2630c58
drivers/block/floppy.c: remove unnecessary return and braces
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
57584c5a38
drivers/block/floppy.c: add function is_ready_state
...
Used a couple of times, might simplify the code a bit.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
29f1c7848f
drivers/block/floppy.c: convert int initialising to bool initialized
...
Don't initialize initialized either. Default is false.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
4d18ef09df
drivers/block/floppy.c: remove #define DEVICE_NAME "floppy"
...
Use it directly in the one place it's used.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
c529730a98
drivers/block/floppy.c: move leading && and || to preceding line
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
74f63f469e
drivers/block/floppy.c: convert int 1/0 to bool true/false
...
Various functions use int where bool is appropriate
lock_fdc, wait_til_done, poll_drive, user_reset_fdc
Convert to bool.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
55eee80c62
drivers/block/floppy.c: remove macros CALL, WAIT and IWAIT
...
Obfuscating macros with embedded returns are not nice
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
86b12b48a2
drivers/block/floppy.c: remove [_]COPYIN [_]COPYOUT and ECALL macros
...
Remove these obfuscating macros with hidden returns
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
4575b55281
drivers/block/floppy.c: remove most uses of CALL and ECALL macros
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
e029853612
drivers/block/floppy.c: remove [U]CLEARF, [U]SETF, and [U]TESTF macros
...
Use clear_bit, set_bit, and test_bit functions directly
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
87f530d8f1
drivers/block/floppy.c: add debug_dcl(...) macro
...
Converted #ifdef DCL_DEBUG if (test) DPRINTK(...); #endif
to debug_dcl(test, ...);
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:30 -08:00
Joe Perches
52a0d61f64
drivers/block/floppy.c: remove macro LOCK_FDC
...
Macros with hidden returns aren't nice.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
a0a52d67de
drivers/block/floppy.c: remove a few spaces from function casts
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
da27365342
drivers/block/floppy.c: remove IN/OUT macros, indent switch/case
...
Remove ugly IN/OUT macros, use direct case and code
Add missing semicolon after ECALL
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
96534f1dd5
drivers/block/floppy.c: indent a comment
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
b87c9e0a88
drivers/block/floppy.c: remove CLEARSTRUCT macro, use memset
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
bb57f0c662
drivers/block/floppy.c: comment neatening and remove naked ;
...
Spacing, column alignment and a for loop with
a naked semicolon converted to an assign and while
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
2300f90e31
drivers/block/floppy.c: remove LAST_OUT macro
...
Macros with hidden returns are not nice.
Convert the 2 uses to use direct code.
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
d7b2b2ecd8
drivers/block/floppy.c: hoist assigns from if()s, neatening
...
Move assigns above if()s
Remove unnecessary parentheses from returns
Use a temporary for a duplicated test
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
045f983630
drivers/block/floppy.c: remove used once CHECK_READY macro
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
a81ee54471
drivers/block/floppy.c: remove unnecessary braces
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
b46df356de
drivers/block/floppy.c: use pr_<level>
...
Convert bare printk to pr_info and pr_cont
Convert printk(KERN_ERR to pr_err
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
48c8cee61f
drivers/block/floppy.c: #define space and column neatening
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:29 -08:00
Joe Perches
d49375434e
drivers/block/floppy.c: convert some #include <asm/ to #include <linux/
...
Signed-off-by: Joe Perches <joe@perches.com >
Cc: Stephen Hemminger <shemminger@vyatta.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-03-12 15:52:28 -08:00
Jiri Kosina
318ae2edc3
Merge branch 'for-next' into for-linus
...
Conflicts:
Documentation/filesystems/proc.txt
arch/arm/mach-u300/include/mach/debug-macro.S
drivers/net/qlge/qlge_ethtool.c
drivers/net/qlge/qlge_main.c
drivers/net/typhoon.c
2010-03-08 16:55:37 +01:00
Emese Revfy
52cf25d0ab
Driver core: Constify struct sysfs_ops in struct kobj_type
...
Constify struct sysfs_ops.
This is part of the ops structure constification
effort started by Arjan van de Ven et al.
Benefits of this constification:
* prevents modification of data that is shared
(referenced) by many other structure instances
at runtime
* detects/prevents accidental (but not intentional)
modification attempts on archs that enforce
read-only kernel data at runtime
* potentially better optimized code as the compiler
can assume that the const data cannot be changed
* the compiler/linker move const data into .rodata
and therefore exclude them from false sharing
Signed-off-by: Emese Revfy <re.emese@gmail.com >
Acked-by: David Teigland <teigland@redhat.com >
Acked-by: Matt Domsch <Matt_Domsch@dell.com >
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com >
Acked-by: Hans J. Koch <hjk@linutronix.de >
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi >
Acked-by: Jens Axboe <jens.axboe@oracle.com >
Acked-by: Stephen Hemminger <shemminger@vyatta.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-03-07 17:04:49 -08:00
Andi Kleen
28812fe11a
driver-core: Add attribute argument to class_attribute show/store
...
Passing the attribute to the low level IO functions allows all kinds
of cleanups, by sharing low level IO code without requiring
an own function for every piece of data.
Also drivers can extend the attributes with own data fields
and use that in the low level function.
This makes the class attributes the same as sysdev_class attributes
and plain attributes.
This will allow further cleanups in drivers.
Full tree sweep converting all users.
Signed-off-by: Andi Kleen <ak@linux.intel.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-03-07 17:04:48 -08:00
Linus Torvalds
b1bf936840
Merge branch 'for-2.6.34' of git://git.kernel.dk/linux-2.6-block
...
* 'for-2.6.34' of git://git.kernel.dk/linux-2.6-block: (38 commits)
block: don't access jiffies when initialising io_context
cfq: remove 8 bytes of padding from cfq_rb_root on 64 bit builds
block: fix for "Consolidate phys_segment and hw_segment limits"
cfq-iosched: quantum check tweak
blktrace: perform cleanup after setup error
blkdev: fix merge_bvec_fn return value checks
cfq-iosched: requests "in flight" vs "in driver" clarification
cciss: Fix problem with scatter gather elements in the scsi half of the driver
cciss: eliminate unnecessary pointer use in cciss scsi code
cciss: do not use void pointer for scsi hba data
cciss: factor out scatter gather chain block mapping code
cciss: fix scatter gather chain block dma direction kludge
cciss: simplify scatter gather code
cciss: factor out scatter gather chain block allocation and freeing
cciss: detect bad alignment of scsi commands at build time
cciss: clarify command list padding calculation
cfq-iosched: rethink seeky detection for SSDs
cfq-iosched: rework seeky detection
block: remove padding from io_context on 64bit builds
block: Consolidate phys_segment and hw_segment limits
...
2010-03-01 09:00:29 -08:00
Stephen Rothwell
91f63d0efa
block: fix for "Consolidate phys_segment and hw_segment limits"
...
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-03-01 10:43:39 +01:00
Stephen M. Cameron
87c3a922a7
cciss: Fix problem with scatter gather elements in the scsi half of the driver
...
cciss: Fix problem with scatter gather elements in the scsi half of the driver
When support for more than 31 scatter gather elements was added to the block
half of the driver, the SCSI half of the driver was not addressed, and the bump
from 31 to 32 scatter gather elements in the command block itself (not chained)
actually broke the SCSI half of the driver, so that any transfer requiring 32
scatter gather elements wouldn't work. This fix also increases the max transfer
size and size of the scatter gather table to the limit supported by the controller
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:32 +01:00
Stephen M. Cameron
bf88737818
cciss: eliminate unnecessary pointer use in cciss scsi code
...
cciss: eliminate unnecessary pointer use in cciss scsi code
An extra level of indirection was being used in some places
for no real reason.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:32 +01:00
Stephen M. Cameron
aad9fb6f2c
cciss: do not use void pointer for scsi hba data
...
cciss: do not use void pointer for scsi hba data
and get rid of related unnecessary type casting
and delete some superfluous and misleading comments nearby.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:32 +01:00
Stephen M. Cameron
d45033ef56
cciss: factor out scatter gather chain block mapping code
...
cciss: factor out scatter gather chain block mapping code
Rationale is I want to use this code from the scsi half of the
driver.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:32 +01:00
Stephen M. Cameron
2ad6cdc20f
cciss: fix scatter gather chain block dma direction kludge
...
cciss: fix scatter gather chain block dma direction kludge
The data direction for the chained block of scatter gather
elements should always be PCI_DMA_TODEVICE, but was mistakenly
set to the direction of the data transfer, then a kludge to
fix it was added, in which pci_dma_sync_single_for_device or
pci_dma_sync_single_for_cpu was called. If the correct direction
is used in the first place, the kludge isn't needed.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:31 +01:00
Stephen M. Cameron
dccc9b563e
cciss: simplify scatter gather code
...
cciss: simplify scatter gather code.
Instead of allocating an array of pointers to a structure
containing an SGDescriptor structure, and two other elements
that aren't really used, just allocate SGDescriptor structs.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:31 +01:00
Stephen M. Cameron
49fc5601ea
cciss: factor out scatter gather chain block allocation and freeing
...
cciss: factor out scatter gather chain block allocation and freeing
Rationale is that I want to use this code from the scsi half of the
driver.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com >
Signed-off-by: Jens Axboe <jens.axboe@oracle.com >
2010-02-28 19:42:31 +01:00