Vitja Makarov
8eeb12e5a2
spi_bfin5xx: use PIO for full duplex, not DMA
...
Use PIO for full-duplex transfers, instead of DMA.
Signed-off-by: Vitja Makarov <vitja.makarov@gmail.com >
Signed-off-by: Bryan Wu <cooloney@kernel.org >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-05-01 08:04:01 -07:00
Kay Sievers
7e38c3c445
spi: fix platform driver hotplug/coldplug
...
Since 43cc71eed1
2008-04-11 08:06:43 -07:00
Michael Hennerich
b9ad8985f2
spi: spi_bfin5xx: remove unused label
...
Remove unused label, and associated compiler warning.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com >
Signed-off-by: Bryan Wu <cooloney@kernel.org >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-04-08 18:25:53 -07:00
Vitja Makarov
f9e522caec
spi: spi_bfin5xx: fix probe() sequencing
...
Fix bug in SPI probe: first initialize peripheral pins, and just after
register spi master device. This fixes problems with SPI drivers built-in
kernel.
Singed-off-by: Vitja Makarov <vitja.makarov@gmail.com >
Signed-off-by: Bryan Wu <cooloney@kernel.org >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-04-08 18:25:53 -07:00
Mike Frysinger
4fb98efacf
spi: spi_bfin5xx build fix
...
Fix breakage cause by overzealous line wrapping; there should be only one
format string.
Signed-off-by: Mike Frysinger <vapier.adi@gmail.com >
Signed-off-by: Bryan Wu <cooloney@kernel.org >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-04-08 18:25:53 -07:00
Mike Frysinger
26fdc1f0df
spi_bfin: headers are not for changelogs
...
Use simpler comment headers, and strip out information that is maintained in
GIT history
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:11 -08:00
Sonic Zhang
13f3e642b2
spi_bfin: wait for tx to complete on write paths
...
SPI writes should also not return until the last bit is sent.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:11 -08:00
Bryan Wu
4fd432d9c7
spi_bfin: wait for tx to complete on full duplex paths
...
Full duplex SPI operation should not read a dummy byte at the first transfer.
Bug and fix by Jean-Christian de Rivaz <jc@eclis.ch >:
http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3678
Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:11 -08:00
Bryan Wu
e26aa015dd
spi_bfin: wait for tx to complete on some cs_chg paths
...
PBX 2 SPI devices need the nonstandard "cs change per word" mechanism.
This patch is one of three updating this driver to make the last data bits get
sent before advancing the transfer ... in this case, before the chipselect
gets deactivated.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:11 -08:00
Bryan Wu
aab0d83ee7
spi_bfin: use more useful GPIO labels
...
Use the SPI driver's name when requesting gpio lines. When there are gpio
conflicts, this helps to narrow down the problems; "bfin-spi" is not
informative.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:11 -08:00
Bryan Wu
8d20d0a7c4
spi_bfin: remove useless fault path
...
Remove useless return status check in restore_state function. Issue was
pointed out by Michael.
Cc: Michael Hennerich <michael.hennerich@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:11 -08:00
Jeff Garzik
15aafa2f9d
Remove pointless casts from void pointers
...
Mostly in and around irq handlers.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com >
Cc: Russell King <rmk@arm.linux.org.uk >
Cc: "Luck Tony" <tony.luck@intel.com >
Cc: Roman Zippel <zippel@linux-m68k.org >
Cc: Geert Uytterhoeven <geert@linux-m68k.org >
Cc: Paul Mackerras <paulus@samba.org >
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Acked-by: Dmitry Torokhov <dtor@mail.ru >
Cc: Karsten Keil <kkeil@suse.de >
Acked-by: "John W. Linville" <linville@tuxdriver.com >
Cc: James Bottomley <James.Bottomley@steeleye.com >
Cc: David Brownell <david-b@pacbell.net >
Cc: "Antonino A. Daplas" <adaplas@pol.net >
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com >
Acked-by: Holger Schurig <hs4233@mail.mn-solutions.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-06 10:41:01 -08:00
Will Newton
6b1a802839
spi_bfin5xx: fix typo in description
...
Signed-off-by: Will Newton <will.newton@gmail.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-10 19:43:55 -08:00
Bryan Wu
092e1fdaf3
Blackfin SPI driver: reconfigure speed_hz and bits_per_word in each spi transfer
...
- reconfigure SPI baud from speed_hz of each spi transfer
- according to spi_transfer.bits_per_word to reprogram register and setup
correct SPI operation handlers
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Bryan Wu
003d922618
Blackfin SPI driver: move hard coded pin_req to board file
...
Remove some sort of bloaty code, try to get these pin_req arrays built at compile-time
- move this static things to the blackfin board file
- add pin_req array to struct bfin5xx_spi_master
- tested on BF537/BF548 with SPI flash
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Bryan Wu
f452126c2e
Blackfin SPI driver: use void __iomem * for regs_base
...
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Bryan Wu
d8c05008b0
Blackfin SPI driver: use cpu_relax() to replace continue in while busywait
...
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Sonic Zhang
07612e5f22
spi: spi_bfin: resequence DMA start/stop
...
Set correct baud for spi mmc and enable SPI only after DMA is started.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Bryan Wu
62310e51ac
spi: spi_bfin: update handling of delay-after-deselect
...
Move cs_chg_udelay handling (specific to this driver) to cs_deactive(), fixing
a bug when some SPI LCD driver needs delay after cs_deactive.
Fix bug reported by Cameron Barfield <cbarfield@cyberdata.net >
https://blackfin.uclinux.org/gf/project/uclinux-dist/forum/?action=ForumBrowse&forum_id=39&_forum_action=ForumMessageBrowse&thread_id=23630&feedback=Message%20replied .
Cc: Cameron Barfield <cbarfield@cyberdata.net >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Bryan Wu
c3061abb9e
spi: spi_bfin: bugfix for 8..16 bit word sizes
...
Fix bug in u16_cs_chg_reader to read data_len-2 bytes data firstly, then read
out the last 2 bytes data
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:20 -08:00
Bryan Wu
bb90eb00b6
spi: spi_bfin: handle multiple spi_masters
...
Move global SPI regs_base and dma_ch to struct driver_data. Test on BF54x SPI
Flash with 2 spi_master devices enabled.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Sonic Zhang
3f479a65b3
spi: spi_bfin: relocate spin/waits
...
Move spin/waits to more correct locations in bfin SPI driver.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Sonic Zhang
cc487e7320
spi: spi_bfin: change handling of communication parameters
...
Fix SPI driver to work with SPI flash ST M25P16 on bf548
Currently the SPI driver enables the SPI controller and sets the SPI baud
register for each SPI transfer. But they should never be changed within a SPI
message session, in which several SPI transfers are pumped.
This patch moves SPI setting to the begining of a message session, and
never disables SPI controller until an error occurs.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Sonic Zhang
12e17c4267
spi: spi_bfin, rearrange portmux calls
...
Move pin muxing to setup and cleanup methods.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Sonic Zhang
7c4ef09449
spi: spi_bfin uses portmux for additional busses
...
Use portmux mechanism to support SPI busses 1 and 2, instead of just the
original bus 0.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Bryan Wu
a32c691d7c
spi: spi_bfin uses platform device resources
...
Update spi driver to support multi-ports by using platform resources; tested
on STAMP537+SPI_MMC, other boards need more testing. Plus other minor
updates.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Mike Frysinger
2ed355165f
spi: spi_bfin, don't bypass spi framework
...
Prevent people from setting bits in ctl_reg that the SPI framework already
handles, hopefully we can one day drop ctl_reg completely
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Bryan Wu
fad91c8909
spi: spi_bfin handles spi_transfer.cs_change
...
Respect per-transfer cs_change field (protocol tweaking support) by
adding and using cs_active/cs_deactive functions.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Bryan Wu
5fec5b5a4e
spi: spi_bfin cleanups, error handling
...
Cleanup and error handling
- add error handling in SPI bus driver with selecting clients
- use proper defines to access Blackfin MMRs
- remove useless SSYNCs
- cleaner use of portmux calls
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Michael Hennerich
cc2f81a695
spi: bfin spi uses portmux calls
...
Use new Blackfin portmux interface, add error handling.
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Bryan Wu
131b17d42d
spi: initial BF54x SPI support
...
Initial BF54x SPI support
- support BF54x SPI0
- clean up some code (whitespace etc)
- will support multiports in the future
- start using portmux calls
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-12-05 09:21:19 -08:00
Joe Perches
898eb71cb1
Add missing newlines to some uses of dev_<level> messages
...
Found these while looking at printk uses.
Add missing newlines to dev_<level> uses
Add missing KERN_<level> prefixes to multiline dev_<level>s
Fixed a wierd->weird spelling typo
Added a newline to a printk
Signed-off-by: Joe Perches <joe@perches.com >
Cc: "Luck, Tony" <tony.luck@intel.com >
Cc: Jens Axboe <jens.axboe@oracle.com >
Cc: Mark M. Hoffman <mhoffman@lightlink.com >
Cc: Roland Dreier <rolandd@cisco.com >
Cc: Tilman Schmidt <tilman@imap.cc >
Cc: David Woodhouse <dwmw2@infradead.org >
Cc: Jeff Garzik <jeff@garzik.org >
Cc: Stephen Hemminger <shemminger@linux-foundation.org >
Cc: Greg KH <greg@kroah.com >
Cc: Jeremy Fitzhardinge <jeremy@goop.org >
Cc: Geert Uytterhoeven <geert@linux-m68k.org >
Cc: Alessandro Zummo <a.zummo@towertech.it >
Cc: David Brownell <david-b@pacbell.net >
Cc: James Smart <James.Smart@Emulex.Com >
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com >
Cc: "Antonino A. Daplas" <adaplas@pol.net >
Cc: Evgeniy Polyakov <johnpol@2ka.mipt.ru >
Cc: Russell King <rmk@arm.linux.org.uk >
Cc: Jaroslav Kysela <perex@suse.cz >
Cc: Takashi Iwai <tiwai@suse.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-10-18 14:37:28 -07:00
Tony Jones
49dce689ad
spi doesn't need class_device
...
Make the SPI framework and drivers stop using class_device. Update docs
accordingly ... highlighting just which sysfs paths should be
"safe"/stable.
Signed-off-by: Tony Jones <tonyj@suse.de >
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Cc: Greg KH <greg@kroah.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-10-16 09:43:10 -07:00
Jesper Juhl
8b7f9b81c8
Clean up duplicate includes in drivers/spi/
...
This patch cleans up duplicate includes in
drivers/spi/
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com >
Acked-by: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-10-16 09:43:09 -07:00
David Brownell
fc3ba9525b
SPI driver hotplug/coldplug fixes
...
Update various SPI drivers so they properly support
- coldplug through "modprobe $(cat /sys/devices/.../modalias)"
- hotplug through "modprobe $(MODALIAS)"
The basic rule for platform, SPI, and (new style) I2C drivers is just
to make sure that modprobing the driver name works. In this case, all
the relevant drivers are platform drivers, and this patch either
(a) Changes the driver name, if no in-tree code would break;
this is simpler and thus preferable in the long term.
(b) Adds MODULE_ALIAS directives, when in-tree platforms declare
devices using the current driver name; less desirable.
Most systems will link SPI controller drivers statically, but
there's no point in being needlessly broken.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net >
Cc: Jean Delvare <khali@linux-fr.org >
Acked-by: Andrei Konovalov <akonovalov@ru.mvista.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-08-31 01:42:22 -07:00
Bryan Wu
d6fe89b063
Blackfin SPI driver: fix bug SPI DMA incomplete transmission
...
SPI writes intermittently drop bytes at end of DMA transfer
http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3205
http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=2892
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
2007-06-11 17:34:17 +08:00
Mike Frysinger
27bb9e79bc
Blackfin SPI driver: tweak spi cleanup function to match newer kernel changes
...
Signed-off-by: Mike Frysinger <michael.frysinger@analog.com >
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: David Brownell <dbrownell@users.sourceforge.net >
2007-06-11 15:31:30 +08:00
Bryan Wu
88b4036934
Blackfin SPI: cleanup according to David Brownell's review
...
a) platorm_driver_probe(...) instead of platform_driver_register(&driver);
b) set bfin_spi_enable and bfin_spi_disable static
c) Why is the width flag a u32?
d) maybe use dev_dbg() instead of pr_debug()
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-21 09:50:24 -07:00
Wu, Bryan
a5f6abd4f7
Blackfin: blackfin on-chip SPI controller driver
...
This patch implements the driver necessary use the Analog Devices Blackfin
processor's SPI Port.
Signed-off-by: Bryan Wu <bryan.wu@analog.com >
Cc: David Brownell <david-b@pacbell.net >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2007-05-07 12:12:58 -07:00
