Steven Rostedt 088e54658f
mm: remove likely() from mapping_unevictable() ...
The mapping_unevictable() has a likely() around the mapping parameter.
This mapping parameter comes from page_mapping() which has an unlikely()
that the page will be set as PAGE_MAPPING_ANON, and if so, it will return
NULL. One would think that this unlikely() means that the mapping
returned by page_mapping() would not be NULL, but where page_mapping() is
used just above mapping_unevictable(), that unlikely() is incorrect most
of the time. This means that the "likely(mapping)" in
mapping_unevictable() is incorrect most of the time.
Running the annotated branch profiler on my main box which runs firefox,
evolution, xchat and is part of my distcc farm, I had this:
correct incorrect % Function File Line
------- --------- - -------- ---- ----
12872836 1269443893 98 mapping_unevictable pagemap.h 51
35935762 1270265395 97 page_mapping mm.h 659
1306198001 143659 0 page_mapping mm.h 657
203131478 121586 0 page_mapping mm.h 657
5415491 1116 0 page_mapping mm.h 657
74899487 1116 0 page_mapping mm.h 657
203132845 224 0 page_mapping mm.h 659
5415464 27 0 page_mapping mm.h 659
13552 0 0 page_mapping mm.h 657
13552 0 0 page_mapping mm.h 659
242630 0 0 page_mapping mm.h 657
242630 0 0 page_mapping mm.h 659
74899487 0 0 page_mapping mm.h 659
The page_mapping() is a static inline, which is why it shows up multiple
times. The mapping_unevictable() is also a static inline but seems to be
used only once in my setup.
The unlikely in page_mapping() was correct a total of 1909540379 times and
incorrect 1270533123 times, with a 39% being incorrect. Perhaps this is
enough to remove the unlikely from page_mapping() as well.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org >
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com >
Acked-by: Nick Piggin <npiggin@kernel.dk >
Acked-by: Rik van Riel <riel@redhat.com >
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2011-01-13 17:32:36 -08:00
2011-01-06 22:32:52 +00:00
2010-08-14 22:26:51 +02:00
2010-10-18 15:16:08 +02:00
2011-01-12 15:15:14 -08:00
2010-10-20 15:37:28 -07:00
2011-01-13 08:03:25 -08:00
2010-08-14 22:26:51 +02:00
2011-01-09 09:10:10 -08:00
2011-01-13 09:58:14 -08:00
2010-12-16 12:37:26 -05:00
2011-01-13 10:32:54 -08:00
2010-10-26 17:54:22 -07:00
2011-01-12 14:37:42 +09:00
2010-10-30 08:31:35 -07:00
2011-01-10 20:11:38 +01:00
2010-10-13 18:00:51 +02:00
2010-10-18 11:22:05 +02:00
2010-10-13 18:00:51 +02:00
2010-10-13 18:00:51 +02:00
2011-01-13 08:03:19 -08:00
2010-08-14 22:26:51 +02:00
2010-08-05 13:26:20 +01:00
2010-08-12 06:38:24 +10:00
2011-01-12 14:33:05 +00:00
2011-01-07 17:08:46 -08:00
2010-12-26 22:37:05 -08:00
2011-01-11 15:11:56 -08:00
2010-08-20 01:42:59 -07:00
2010-08-24 14:48:10 -07:00
2011-01-13 08:03:08 -08:00
2011-01-07 13:16:28 -08:00
2010-10-15 21:18:59 +02:00
2010-12-11 01:28:58 -05:00
2010-11-23 20:14:46 +00:00
2010-08-01 19:36:03 -04:00
2010-10-22 10:20:08 -07:00
2010-10-21 20:21:03 -04:00
2010-12-10 15:45:05 -08:00
2010-11-12 07:55:30 -08:00
2011-01-10 08:51:44 -08:00
2010-08-09 00:13:34 +02:00
2010-12-06 15:58:43 -05:00
2010-10-26 16:52:10 -07:00
2010-10-27 18:03:06 -07:00
2011-01-10 13:31:14 -08:00
2011-01-13 08:03:12 -08:00
2010-11-10 14:54:09 +01:00
2011-01-07 17:50:31 +11:00
2010-11-15 13:27:04 -05:00
2010-11-10 14:54:09 +01:00
2011-01-13 10:45:01 -08:00
2010-08-07 18:26:29 +02:00
2010-12-13 16:11:13 -08:00
2010-10-25 21:18:20 -04:00
2010-11-29 08:35:12 +11:00
2011-01-13 08:03:17 -08:00
2010-12-16 17:53:38 +01:00
2010-11-01 15:38:34 -04:00
2010-11-26 10:51:04 +00:00
2010-07-27 12:40:55 +02:00
2010-12-20 09:07:35 -08:00
2010-10-25 08:02:40 -07:00
2011-01-13 17:32:34 -08:00
2010-09-14 16:08:45 -07:00
2010-06-29 15:29:31 -07:00
2010-08-09 20:45:04 -07:00
2010-08-19 17:17:59 -07:00
2011-01-05 14:15:50 +01:00
2010-10-24 14:20:01 -07:00
2010-08-10 13:47:42 -07:00
2010-12-16 16:15:34 -08:00
2010-10-14 14:32:06 -07:00
2010-08-08 14:55:26 -04:00
2010-11-10 16:57:11 -08:00
2010-08-03 13:47:04 -04:00
2010-09-30 21:19:22 -04:00
2011-01-13 08:03:22 -08:00
2010-11-30 13:39:55 +00:00
2010-08-19 17:18:00 -07:00
2011-01-13 08:03:13 -08:00
2010-09-24 07:40:30 -07:00
2011-01-10 07:38:53 -08:00
2010-12-31 10:50:54 -08:00
2010-12-07 13:47:12 +01:00
2011-01-10 08:51:44 -08:00
2010-08-17 09:11:10 +02:00
2010-08-04 11:00:45 +02:00
2011-01-13 20:00:02 +00:00
2011-01-10 16:10:33 -08:00
2010-09-07 14:17:10 -05:00
2011-01-13 19:59:58 +00:00
2011-01-13 19:59:52 +00:00
2010-09-22 17:22:38 -07:00
2011-01-03 01:41:40 -08:00
2010-11-26 09:57:36 +01:00
2010-07-30 09:36:01 -07:00
2010-07-28 09:59:01 -04:00
2010-08-05 17:17:51 +00:00
2010-07-21 16:01:46 +02:00
2010-10-14 18:38:42 +02:00
2010-10-14 18:38:20 +02:00
2010-10-22 15:55:22 +02:00
2011-01-07 23:36:59 -05:00
2010-10-21 14:47:59 +02:00
2010-06-30 15:00:50 -04:00
2010-12-17 15:07:19 +01:00
2011-01-10 16:05:30 -08:00
2010-12-10 15:55:23 -08:00
2010-10-23 09:24:34 +09:00
2011-01-10 19:04:07 +01:00
2011-01-12 20:16:43 -05:00
2010-12-15 13:56:33 -05:00
2010-12-22 12:56:10 +09:00
2010-10-18 11:03:14 +02:00
2010-08-19 17:18:03 -07:00
2011-01-09 15:42:55 -08:00
2010-12-08 10:30:34 -08:00
2010-11-01 15:38:34 -04:00
2011-01-04 08:48:34 +01:00
2011-01-10 08:51:44 -08:00
2010-11-30 17:28:57 -05:00
2011-01-07 17:50:27 +11:00
2011-01-13 10:45:01 -08:00
2010-07-22 22:58:58 +02:00
2010-07-11 22:22:23 +02:00
2010-10-22 10:22:17 -07:00
2010-11-15 13:49:51 +09:00
2011-01-07 17:50:23 +11:00
2011-01-07 17:50:23 +11:00
2010-11-19 10:18:47 -05:00
2010-07-21 11:00:25 -04:00
2010-12-07 20:16:56 +01:00
2010-09-14 00:23:59 -07:00
2011-01-07 17:50:29 +11:00
2011-01-13 14:47:54 +01:00
2010-12-06 23:52:08 +01:00
2010-12-06 17:15:15 -08:00
2010-10-25 14:11:37 -07:00
2011-01-10 22:11:23 +01:00
2011-01-13 17:26:46 -08:00
2010-11-18 10:56:29 -08:00
2011-01-13 09:58:38 -08:00
2010-09-24 14:03:44 +02:00
2010-12-17 15:18:04 +01:00
2011-01-10 07:38:53 -08:00
2010-10-12 16:53:37 +02:00
2010-08-11 09:23:22 +02:00
2010-10-08 09:32:46 +02:00
2010-11-12 14:51:55 +01:00
2010-11-15 22:40:38 +01:00
2010-08-11 18:21:02 +02:00
2010-11-09 09:31:10 -08:00
2011-01-10 22:11:23 +01:00
2010-06-30 01:21:38 -07:00
2010-10-26 17:40:56 -07:00
2010-12-20 14:49:47 -05:00
2010-11-19 17:47:57 +08:00
2010-10-05 20:26:58 -07:00
2011-01-11 23:55:51 +01:00
2011-01-06 11:10:05 -08:00
2010-08-22 21:15:39 -07:00
2010-08-22 21:15:39 -07:00
2010-10-18 11:03:14 +02:00
2010-11-22 08:24:29 -08:00
2010-11-16 10:58:30 -08:00
2010-09-21 18:04:47 -07:00
2010-11-12 12:30:57 -08:00
2010-08-29 21:57:55 -07:00
2011-01-04 11:29:52 -08:00
2010-10-21 16:08:28 +02:00
2010-08-19 17:16:23 -07:00
2010-12-06 12:59:05 -08:00
2011-01-06 10:23:33 -08:00
2010-10-22 10:21:26 -07:00
2010-07-28 10:18:49 -04:00
2011-01-13 09:58:14 -08:00
2010-10-07 15:03:44 -07:00
2010-08-03 09:49:09 -04:00
2010-11-10 10:21:22 +01:00
2010-10-26 16:52:08 -07:00
2010-07-09 11:42:03 -07:00
2010-11-11 13:40:11 +01:00
2010-08-09 20:45:05 -07:00
2010-07-19 15:44:25 +02:00
2010-12-17 10:01:09 -08:00
2010-10-04 22:45:24 +09:00
2010-11-24 11:16:42 -08:00
2010-10-18 19:58:50 +02:00
2010-10-26 10:33:27 +02:00
2011-01-13 17:32:31 -08:00
2010-10-07 14:08:55 +01:00
2010-10-28 11:58:39 +02:00
2010-08-10 13:47:40 -07:00
2011-01-10 12:29:43 -05:00
2010-08-10 11:49:21 -07:00
2010-12-09 20:17:07 -08:00
2010-10-18 19:58:57 +02:00
2010-10-29 14:45:29 -04:00
2010-08-12 11:27:58 +02:00
2011-01-13 10:25:58 -08:00
2010-10-22 15:34:12 -05:00
2011-01-13 17:32:31 -08:00
2011-01-13 17:32:33 -08:00
2010-08-19 17:18:00 -07:00
2010-10-27 18:03:18 -07:00
2010-10-29 13:14:41 -05:00
2011-01-13 08:03:07 -08:00
2010-08-23 18:12:46 -07:00
2010-10-22 10:16:44 -07:00
2011-01-07 17:02:58 -08:00
2011-01-07 08:43:37 +01:00
2010-07-27 20:48:19 -07:00
2010-09-09 18:57:24 -07:00
2010-12-22 10:27:53 +01:00
2011-01-12 11:30:50 +02:00
2010-10-24 10:50:49 +02:00
2011-01-12 11:23:08 +02:00
2011-01-12 11:23:12 +02:00
2011-01-13 08:03:06 -08:00
2011-01-13 08:03:05 -08:00
2010-11-12 07:55:32 -08:00
2010-09-09 09:09:43 -07:00
2011-01-05 19:43:22 -05:00
2010-10-25 14:11:39 -07:00
2011-01-07 17:50:31 +11:00
2010-10-25 21:24:15 -04:00
2010-10-21 14:11:46 -07:00
2010-08-02 15:35:11 +10:00
2010-10-28 09:08:47 -05:00
2010-11-22 08:34:23 -08:00
2010-10-26 16:52:19 -07:00
2011-01-10 19:04:08 +01:00
2010-12-06 11:03:46 -08:00
2010-10-12 15:37:51 -07:00
2010-08-11 08:59:19 -07:00
2010-12-02 14:51:15 -08:00
2010-10-22 10:16:44 -07:00
2010-08-09 20:44:56 -07:00
2011-01-13 17:32:34 -08:00
2010-08-21 00:37:40 -07:00
2010-10-26 16:52:05 -07:00
2011-01-13 17:32:36 -08:00
2010-08-09 20:44:58 -07:00
2010-10-28 09:02:15 -07:00
2011-01-13 17:32:31 -08:00
2010-12-23 09:48:41 +01:00
2010-10-26 16:52:13 -07:00
2011-01-07 17:50:33 +11:00
2010-10-03 21:50:53 -07:00
2010-10-12 16:53:34 +02:00
2010-10-08 17:16:22 -05:00
2010-11-26 15:05:34 +01:00
2010-06-30 13:01:11 -07:00
2010-10-18 11:03:14 +02:00
2011-01-07 17:50:27 +11:00
2010-08-22 21:15:39 -07:00
2011-01-12 20:03:43 -05:00
2011-01-12 20:03:43 -05:00
2010-08-22 21:15:39 -07:00
2011-01-07 17:50:26 +11:00
2011-01-10 16:05:30 -08:00
2010-11-17 10:54:34 -08:00
2010-12-17 12:03:14 -08:00
2010-10-18 08:32:07 -07:00
2010-12-16 12:37:23 -05:00
2011-01-11 14:17:09 -05:00
2011-01-06 14:57:46 -05:00
2011-01-07 17:50:29 +11:00
2010-10-07 18:48:49 -04:00
2010-09-23 08:55:58 -04:00
2010-12-07 23:02:44 -05:00
2011-01-06 16:03:13 -05:00
2010-10-23 09:24:39 +09:00
2010-12-20 14:49:47 -05:00
2010-12-22 22:15:32 +01:00
2010-11-10 16:57:11 -08:00
2010-08-19 17:18:02 -07:00
2010-12-23 15:57:48 -07:00
2010-10-21 11:10:10 -06:00
2011-01-08 21:42:42 -07:00
2010-07-05 16:14:30 -06:00
2010-07-05 16:14:52 -06:00
2010-10-21 11:34:55 -06:00
2010-11-01 01:08:14 -04:00
2010-10-12 21:58:08 -06:00
2010-08-06 09:25:50 -06:00
2010-07-30 00:03:59 -06:00
2010-07-30 00:03:58 -06:00
2010-08-08 10:02:59 -07:00
2010-08-11 08:59:19 -07:00
2010-10-17 01:57:50 +02:00
2010-10-15 12:45:44 +02:00
2010-09-03 19:09:46 +08:00
2010-11-25 06:50:40 +09:00
2011-01-13 17:32:35 -08:00
2010-10-26 16:52:05 -07:00
2011-01-13 17:32:36 -08:00
2011-01-07 17:50:33 +11:00
2010-08-04 14:12:05 -07:00
2011-01-13 08:03:21 -08:00
2010-10-17 20:03:03 -07:00
2010-10-17 20:03:06 -07:00
2010-10-27 21:30:13 -04:00
2010-10-27 17:53:25 +02:00
2010-12-18 15:54:04 +01:00
2010-12-16 11:36:43 +01:00
2010-10-13 14:40:34 -07:00
2010-10-24 15:07:11 -07:00
2011-01-10 07:38:54 -08:00
2010-08-21 23:40:14 -07:00
2010-10-22 10:16:42 -07:00
2010-07-19 01:58:48 +02:00
2010-07-19 02:00:34 +02:00
2010-12-24 15:04:06 +01:00
2010-10-17 01:57:43 +02:00
2010-12-24 15:04:41 +01:00
2010-07-19 01:58:48 +02:00
2010-08-11 09:21:15 +02:00
2010-12-10 15:06:43 +01:00
2011-01-07 17:50:29 +11:00
2010-07-16 09:48:45 +02:00
2010-10-06 17:37:22 +04:00
2010-08-04 21:53:17 -07:00
2011-01-13 08:03:21 -08:00
2011-01-13 08:03:21 -08:00
2011-01-13 08:03:10 -08:00
2010-07-18 19:15:26 -07:00
2010-10-27 18:03:10 -07:00
2010-11-12 07:55:33 -08:00
2010-12-02 17:55:12 +01:00
2010-08-18 23:30:42 -07:00
2011-01-10 19:04:05 +01:00
2010-11-12 07:55:32 -08:00
2010-10-29 04:16:31 -04:00
2010-10-27 18:03:18 -07:00
2010-11-29 11:17:22 -08:00
2010-10-26 16:52:16 -07:00
2010-07-05 14:43:50 +02:00
2011-01-07 17:50:31 +11:00
2010-08-19 17:18:00 -07:00
2010-12-17 12:34:59 -08:00
2010-12-17 12:34:08 -08:00
2010-11-29 22:01:58 -08:00
2010-11-29 22:01:58 -08:00
2010-09-08 18:16:55 -07:00
2010-08-09 16:47:27 -04:00
2010-11-17 08:59:32 -08:00
2011-01-07 17:50:29 +11:00
2010-11-12 07:55:30 -08:00
2010-10-17 01:57:50 +02:00
2010-11-15 13:24:06 -05:00
2010-10-20 13:37:56 -04:00
2011-01-13 08:03:17 -08:00
2011-01-13 08:03:18 -08:00
2010-10-27 18:03:16 -07:00
2011-01-13 08:03:18 -08:00
2010-10-26 16:52:09 -07:00
2011-01-13 08:03:23 -08:00
2010-12-13 22:48:21 +01:00
2010-11-15 11:29:30 -08:00
2010-07-23 17:08:41 +04:00
2011-01-13 17:32:35 -08:00
2011-01-10 09:46:24 +11:00
2010-10-22 10:20:06 -07:00
2010-10-21 10:12:48 +11:00
2010-10-30 12:12:50 +02:00
2011-01-07 17:50:27 +11:00
2010-10-22 10:20:10 -07:00
2011-01-13 08:03:19 -08:00
2010-08-10 13:47:46 -07:00
2010-11-30 14:11:49 -08:00
2011-01-13 15:06:28 +09:00
2010-09-03 17:29:04 -07:00
2010-10-18 09:33:31 -07:00
2010-11-09 14:45:52 +01:00
2010-11-15 18:48:25 +09:00
2010-11-09 16:38:20 +09:00
2010-10-04 03:54:56 +09:00
2010-10-31 10:40:39 -04:00
2010-08-09 20:44:58 -07:00
2010-10-08 09:32:15 +02:00
2010-12-16 14:43:14 -08:00
2010-11-28 21:16:28 +02:00
2011-01-07 17:50:16 +11:00
2010-08-11 08:59:21 -07:00
2010-11-06 09:04:33 +02:00
2010-11-17 14:58:36 -08:00
2010-10-27 17:28:36 +01:00
2010-12-08 12:16:33 -08:00
2011-01-13 10:25:58 -08:00
2011-01-10 12:00:22 -05:00
2010-10-07 14:08:55 +01:00
2010-08-20 09:00:15 -07:00
2010-11-18 14:37:34 +01:00
2010-08-09 16:48:44 -04:00
2010-11-24 11:14:24 -08:00
2010-10-14 08:55:28 +02:00
2011-01-13 10:05:56 -08:00
2010-10-26 16:52:05 -07:00
2010-10-27 18:03:14 -07:00
2010-11-18 14:37:45 +01:00
2010-10-17 01:57:44 +02:00
2010-08-21 00:34:45 -07:00
2010-08-11 08:59:22 -07:00
2010-12-22 19:43:34 -08:00
2010-08-30 13:23:33 -07:00
2010-09-18 12:19:21 +02:00
2010-10-14 12:41:10 -07:00
2011-01-13 08:03:21 -08:00
2010-10-22 14:46:25 +02:00
2010-12-11 12:34:34 +01:00
2011-01-13 08:03:20 -08:00
2011-01-01 13:57:56 -08:00
2011-01-01 13:57:56 -08:00
2010-09-09 20:41:20 +02:00
2011-01-13 08:03:08 -08:00
2010-11-29 08:55:25 +11:00
2010-11-29 08:55:22 +11:00
2010-10-27 18:03:12 -07:00
2011-01-07 20:57:22 -05:00
2010-12-16 13:14:32 -08:00
2011-01-13 08:03:20 -08:00
2010-12-02 12:58:16 -08:00
2010-10-26 16:52:03 -07:00
2010-11-28 23:08:04 +01:00
2010-12-20 09:37:33 +01:00
2010-11-10 16:57:11 -08:00
2010-10-22 10:22:05 -07:00
2010-12-16 10:05:06 -08:00
2011-01-13 08:03:18 -08:00
2011-01-06 13:05:04 +10:00
2010-08-27 09:10:44 +10:00
2010-11-10 12:04:41 +09:00
2010-12-11 02:01:35 -05:00
2010-10-21 07:55:58 -02:00
2010-10-27 18:03:18 -07:00
2011-01-13 17:32:34 -08:00
2011-01-13 17:32:31 -08:00
2010-08-10 13:47:44 -07:00
2010-10-05 11:47:18 -07:00
2010-10-13 15:45:21 -04:00
2010-11-15 13:25:02 -05:00
2011-01-07 16:58:04 -08:00
2010-10-30 09:05:48 -07:00
2010-12-07 14:04:02 -08:00
2010-12-10 14:43:58 -08:00
2011-01-13 08:03:24 -08:00
088e54658f