Hidetoshi Seto 0cf55e1ec0
sched, cputime: Introduce thread_group_times() ...
This is a real fix for problem of utime/stime values decreasing
described in the thread:
http://lkml.org/lkml/2009/11/3/522
Now cputime is accounted in the following way:
- {u,s}time in task_struct are increased every time when the thread
is interrupted by a tick (timer interrupt).
- When a thread exits, its {u,s}time are added to signal->{u,s}time,
after adjusted by task_times().
- When all threads in a thread_group exits, accumulated {u,s}time
(and also c{u,s}time) in signal struct are added to c{u,s}time
in signal struct of the group's parent.
So {u,s}time in task struct are "raw" tick count, while
{u,s}time and c{u,s}time in signal struct are "adjusted" values.
And accounted values are used by:
- task_times(), to get cputime of a thread:
This function returns adjusted values that originates from raw
{u,s}time and scaled by sum_exec_runtime that accounted by CFS.
- thread_group_cputime(), to get cputime of a thread group:
This function returns sum of all {u,s}time of living threads in
the group, plus {u,s}time in the signal struct that is sum of
adjusted cputimes of all exited threads belonged to the group.
The problem is the return value of thread_group_cputime(),
because it is mixed sum of "raw" value and "adjusted" value:
group's {u,s}time = foreach(thread){{u,s}time} + exited({u,s}time)
This misbehavior can break {u,s}time monotonicity.
Assume that if there is a thread that have raw values greater
than adjusted values (e.g. interrupted by 1000Hz ticks 50 times
but only runs 45ms) and if it exits, cputime will decrease (e.g.
-5ms).
To fix this, we could do:
group's {u,s}time = foreach(t){task_times(t)} + exited({u,s}time)
But task_times() contains hard divisions, so applying it for
every thread should be avoided.
This patch fixes the above problem in the following way:
- Modify thread's exit (= __exit_signal()) not to use task_times().
It means {u,s}time in signal struct accumulates raw values instead
of adjusted values. As the result it makes thread_group_cputime()
to return pure sum of "raw" values.
- Introduce a new function thread_group_times(*task, *utime, *stime)
that converts "raw" values of thread_group_cputime() to "adjusted"
values, in same calculation procedure as task_times().
- Modify group's exit (= wait_task_zombie()) to use this introduced
thread_group_times(). It make c{u,s}time in signal struct to
have adjusted values like before this patch.
- Replace some thread_group_cputime() by thread_group_times().
This replacements are only applied where conveys the "adjusted"
cputime to users, and where already uses task_times() near by it.
(i.e. sys_times(), getrusage(), and /proc/<PID>/stat.)
This patch have a positive side effect:
- Before this patch, if a group contains many short-life threads
(e.g. runs 0.9ms and not interrupted by ticks), the group's
cputime could be invisible since thread's cputime was accumulated
after adjusted: imagine adjustment function as adj(ticks, runtime),
{adj(0, 0.9) + adj(0, 0.9) + ....} = {0 + 0 + ....} = 0.
After this patch it will not happen because the adjustment is
applied after accumulated.
v2:
- remove if()s, put new variables into signal_struct.
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com >
Acked-by: Peter Zijlstra <peterz@infradead.org >
Cc: Spencer Candland <spencer@bluehost.com >
Cc: Americo Wang <xiyou.wangcong@gmail.com >
Cc: Oleg Nesterov <oleg@redhat.com >
Cc: Balbir Singh <balbir@in.ibm.com >
Cc: Stanislaw Gruszka <sgruszka@redhat.com >
LKML-Reference: <4B162517.8040909@jp.fujitsu.com >
Signed-off-by: Ingo Molnar <mingo@elte.hu >
2009-12-02 17:32:40 +01:00
2009-09-22 20:49:04 +01:00
2009-09-04 02:16:14 -07:00
2009-08-07 10:39:56 -07:00
2009-09-19 00:51:34 -03:00
2009-10-09 13:32:24 -07:00
2009-08-27 22:05:39 -07:00
2009-07-25 20:16:01 +02:00
2009-09-22 07:54:33 -07:00
2009-09-26 10:50:47 -07:00
2009-06-05 10:36:24 -07:00
2009-10-11 11:20:58 -07:00
2009-09-20 05:55:36 -07:00
2009-08-25 16:07:58 +02:00
2009-08-24 14:56:30 +02:00
2009-08-24 14:56:30 +02:00
2009-08-24 14:56:30 +02:00
2009-08-24 14:56:30 +02:00
2009-09-23 07:39:29 -07:00
2009-06-18 08:46:47 +10:00
2009-09-22 13:32:45 +01:00
2009-09-26 10:49:42 -07:00
2009-09-09 11:19:00 -04:00
2009-09-23 14:36:38 -04:00
2009-09-24 07:21:05 -07:00
2009-10-09 13:52:05 -07:00
2009-06-11 03:30:20 -07:00
2009-09-19 02:14:45 -04:00
2009-06-17 00:36:36 -04:00
2009-09-27 11:39:25 -07:00
2009-03-26 18:14:14 +01:00
2009-09-20 16:09:20 +05:30
2009-09-23 07:39:29 -07:00
2009-09-01 01:14:07 -07:00
2009-09-08 17:42:50 -07:00
2009-10-06 00:26:26 -04:00
2009-09-30 16:12:20 -07:00
2009-04-08 20:47:48 +02:00
2009-03-26 18:14:15 +01:00
2009-03-26 18:14:15 +01:00
2009-09-15 09:50:47 -07:00
2009-06-24 00:00:52 -04:00
2009-04-01 08:59:23 -07:00
2009-06-01 06:21:13 +00:00
2009-09-26 00:10:40 +02:00
2009-09-21 21:03:58 +01:00
2009-09-24 07:21:01 -07:00
2009-09-11 14:33:31 +02:00
2009-08-21 09:26:15 -07:00
2009-04-23 10:06:35 +01:00
2009-09-11 14:33:32 +02:00
2009-10-05 11:03:58 +02:00
2009-10-01 21:19:34 +02:00
2009-09-22 07:17:38 -07:00
2009-03-28 13:30:43 -07:00
2009-04-16 07:47:49 -07:00
2009-06-16 19:47:48 -07:00
2009-06-15 15:49:34 +02:00
2009-09-21 15:14:51 +02:00
2009-07-31 12:28:46 +02:00
2009-06-11 21:36:09 -04:00
2009-10-01 16:11:11 -07:00
2009-06-04 17:45:43 +01:00
2009-07-10 17:32:55 +02:00
2009-08-28 20:25:24 +02:00
2009-03-26 18:14:15 +01:00
2009-09-23 07:39:29 -07:00
2009-04-30 19:24:24 +02:00
2009-06-18 13:03:57 -07:00
2009-03-26 18:14:23 +01:00
2009-03-12 21:33:03 +00:00
2009-06-12 21:46:57 +09:30
2009-09-24 07:20:57 -07:00
2009-10-02 10:54:05 -07:00
2009-07-16 09:19:16 -07:00
2009-03-24 16:38:26 -07:00
2009-08-15 19:02:07 +02:00
2009-10-29 07:39:24 -07:00
2009-09-24 09:34:53 +09:30
2009-06-16 19:47:31 -07:00
2009-06-11 21:36:10 -04:00
2009-07-12 12:22:34 -07:00
2009-09-23 11:01:25 -07:00
2009-07-14 20:29:57 +08:00
2009-09-19 13:13:31 -07:00
2009-09-10 10:00:05 -07:00
2009-06-11 21:36:06 -04:00
2009-09-01 01:24:30 -07:00
2009-04-14 11:11:52 +02:00
2009-09-24 07:20:57 -07:00
2009-09-18 09:48:52 -07:00
2009-09-04 20:40:25 +01:00
2009-10-30 14:59:51 -07:00
2009-03-26 18:14:15 +01:00
2009-05-07 10:14:26 -05:00
2009-04-02 19:55:30 +01:00
2009-06-22 10:12:30 +01:00
2009-09-04 20:40:34 +01:00
2009-05-18 14:46:26 +01:00
2009-04-15 12:22:37 +02:00
2009-08-28 14:24:10 +10:00
2009-09-08 17:55:21 -07:00
2009-06-23 22:09:17 +01:00
2009-09-08 21:17:48 -04:00
2009-06-11 14:57:53 -04:00
2009-04-03 14:53:32 -07:00
2009-09-14 17:41:42 -07:00
2009-04-01 15:42:34 -07:00
2009-04-16 16:17:11 -07:00
2009-06-17 09:33:49 -07:00
2009-06-15 21:30:26 -07:00
2009-05-11 09:52:18 +02:00
2009-10-06 10:35:10 +02:00
2009-07-08 09:18:05 -07:00
2009-08-22 17:52:13 -05:00
2009-05-05 12:26:24 -07:00
2009-09-02 23:07:39 -07:00
2009-09-23 07:39:29 -07:00
2009-03-16 08:32:27 -06:00
2009-11-11 15:22:49 +01:00
2009-07-15 21:30:46 +02:00
2009-06-24 08:15:27 -04:00
2009-09-12 00:16:27 +08:00
2009-04-03 12:13:03 +02:00
2009-04-13 15:04:30 -07:00
2009-06-18 19:50:21 +08:00
2009-03-24 20:56:50 +01:00
2009-09-12 14:48:40 +02:00
2009-06-16 19:47:28 -07:00
2009-06-15 21:30:25 -07:00
2009-09-22 07:17:47 -07:00
2009-04-27 02:53:51 -07:00
2009-03-31 23:00:26 -04:00
2009-10-04 12:39:14 -07:00
2009-04-03 16:42:37 +01:00
2009-04-03 16:42:39 +01:00
2009-06-18 13:03:42 -07:00
2009-07-21 15:26:27 -04:00
2009-06-11 14:57:54 -04:00
2009-09-18 07:25:44 +02:00
2009-10-07 15:52:09 -04:00
2009-07-08 18:17:58 +02:00
2009-10-08 12:16:35 -07:00
2009-05-09 16:10:18 -07:00
2009-06-18 13:04:05 -07:00
2009-08-17 21:33:49 -07:00
2009-10-06 20:16:55 +02:00
2009-09-23 07:39:29 -07:00
2009-08-25 13:44:04 +01:00
2009-09-23 07:39:46 -07:00
2009-09-11 13:23:18 -07:00
2009-09-19 13:13:31 -07:00
2009-09-01 01:13:31 -07:00
2009-04-01 21:42:26 +02:00
2009-06-26 10:48:34 +02:00
2009-09-17 15:15:11 +02:00
2009-06-16 19:47:41 -07:00
2009-08-14 15:59:30 +02:00
2009-09-27 11:39:25 -07:00
2009-03-28 21:34:44 +01:00
2009-09-19 00:16:14 -03:00
2009-06-13 10:39:28 +01:00
2009-03-28 21:34:45 +01:00
2009-11-07 13:10:46 +01:00
2009-05-28 20:52:40 -04:00
2009-09-17 23:23:45 -07:00
2009-08-12 22:13:15 -07:00
2009-09-01 17:52:57 -07:00
2009-04-02 19:04:53 -07:00
2009-08-28 14:40:24 -04:00
2009-09-11 12:54:58 -07:00
2009-03-26 18:14:15 +01:00
2009-08-19 23:08:24 +04:00
2009-07-26 19:25:44 -07:00
2009-09-07 01:56:33 -07:00
2009-05-21 15:13:39 -07:00
2009-03-26 18:14:14 +01:00
2009-07-17 10:11:00 -07:00
2009-09-26 20:28:07 -07:00
2009-04-16 02:02:07 -07:00
2009-05-18 22:19:19 -07:00
2009-09-15 02:37:40 -07:00
2009-06-29 08:59:10 +10:00
2009-06-02 00:45:24 -07:00
2009-07-27 18:39:45 -07:00
2009-09-21 14:28:04 +02:00
2009-10-02 15:42:19 +02:00
2009-09-17 23:23:58 -07:00
2009-09-11 16:40:10 +01:00
2009-10-11 11:20:58 -07:00
2009-08-26 15:41:16 -07:00
2009-07-31 08:55:48 +02:00
2009-03-24 09:42:54 +00:00
2009-09-23 07:39:41 -07:00
2009-07-15 08:17:02 +01:00
2009-03-26 18:14:15 +01:00
2009-06-18 13:03:56 -07:00
2009-09-26 10:17:19 -07:00
2009-04-21 13:41:48 -07:00
2009-03-31 01:14:44 +04:00
2009-04-21 13:41:48 -07:00
2009-06-01 03:07:33 -07:00
2009-09-11 13:21:31 -07:00
2009-03-13 01:32:36 +01:00
2009-08-29 15:53:00 +02:00
2009-03-24 12:15:23 +01:00
2009-03-30 12:43:22 -03:00
2009-03-26 18:14:15 +01:00
2009-09-30 00:32:06 -04:00
2009-09-23 07:39:58 -07:00
2009-03-26 18:14:17 +01:00
2009-11-26 12:59:20 +01:00
2009-03-31 13:05:32 +10:30
2009-10-22 16:39:28 +10:30
2009-10-25 17:31:30 +01:00
2009-10-11 23:21:25 +02:00
2009-09-02 21:29:22 +10:00
2009-06-14 13:50:36 -07:00
2009-09-02 21:29:22 +10:00
2009-09-19 13:13:17 -07:00
2009-09-23 07:39:29 -07:00
2009-08-27 14:29:16 +01:00
2009-04-14 22:05:43 -04:00
2009-04-09 07:49:44 -07:00
2009-03-24 16:38:26 -07:00
2009-09-15 23:51:31 -04:00
2009-09-26 10:17:19 -07:00
2009-09-22 07:17:33 -07:00
2009-09-18 21:22:08 +02:00
2009-09-10 08:33:20 +03:00
2009-06-10 11:48:27 +03:00
2009-09-10 08:33:16 +03:00
2009-04-06 16:06:26 +01:00
2009-04-06 16:06:26 +01:00
2009-06-23 20:21:38 +01:00
2009-06-23 20:21:39 +01:00
2009-07-30 16:03:45 +09:30
2009-07-30 16:03:46 +09:30
2009-10-06 00:26:27 -04:00
2009-09-17 23:23:45 -07:00
2009-09-21 06:27:08 +02:00
2009-06-16 19:47:57 -07:00
2009-09-22 07:17:48 -07:00
2009-06-13 12:28:57 +02:00
2009-08-31 17:30:14 -10:00
2009-08-02 15:41:37 +02:00
2009-04-28 07:37:28 +02:00
2009-08-17 08:37:18 +10:00
2009-09-23 07:39:42 -07:00
2009-06-16 19:47:48 -07:00
2009-03-26 18:14:15 +01:00
2009-06-09 00:53:21 +04:00
2009-08-18 20:13:03 -07:00
2009-09-24 07:20:59 -07:00
2009-09-23 07:39:41 -07:00
2009-04-05 11:04:19 -07:00
2009-09-22 07:17:35 -07:00
2009-06-16 08:40:20 +02:00
2009-04-29 17:32:35 -07:00
2009-09-19 12:50:38 -07:00
2009-05-25 00:55:30 -07:00
2009-07-25 20:18:16 +02:00
2009-09-21 15:14:56 +02:00
2009-09-22 07:17:37 -07:00
2009-09-27 11:39:25 -07:00
2009-09-24 17:20:20 -07:00
2009-05-02 15:36:10 -07:00
2009-04-29 11:33:34 +02:00
2009-09-22 07:17:42 -07:00
2009-09-22 07:17:31 -07:00
2009-09-24 07:21:04 -07:00
2009-07-08 09:31:56 -07:00
2009-09-23 07:39:43 -07:00
2009-09-25 00:32:58 +09:30
2009-10-29 08:56:17 +10:30
2009-06-11 21:36:02 -04:00
2009-04-01 07:38:54 -04:00
2009-09-30 16:12:20 -07:00
2009-09-30 16:12:20 -07:00
2009-03-20 10:48:14 -07:00
2009-04-30 09:01:34 +02:00
2009-09-21 15:14:51 +02:00
2009-03-27 14:44:00 -04:00
2009-03-04 00:03:08 -08:00
2009-07-12 20:11:17 -07:00
2009-09-30 16:12:20 -07:00
2009-10-07 13:53:11 -07:00
2009-09-30 16:12:20 -07:00
2009-09-24 15:44:05 -07:00
2009-03-28 23:55:58 -07:00
2009-06-17 18:02:11 -07:00
2009-06-17 18:02:11 -07:00
2009-09-22 07:54:33 -07:00
2009-08-09 15:06:19 -04:00
2009-09-26 10:17:19 -07:00
2009-04-03 16:42:43 +01:00
2009-06-17 12:24:34 -07:00
2009-06-17 18:02:11 -07:00
2009-03-10 20:33:18 -04:00
2009-04-07 08:31:20 -07:00
2009-08-14 09:13:43 -04:00
2009-08-19 23:08:22 +04:00
2009-06-15 21:44:43 -07:00
2009-08-03 09:56:52 +02:00
2009-08-07 10:39:55 -07:00
2009-09-15 02:37:40 -07:00
2009-03-31 23:00:27 -04:00
2009-07-22 09:27:18 -07:00
2009-05-02 15:36:10 -07:00
2009-04-27 02:53:45 -07:00
2009-09-22 07:17:38 -07:00
2009-07-20 16:33:53 +02:00
2009-09-24 07:20:58 -07:00
2009-04-01 08:59:13 -07:00
2009-09-24 07:53:22 -07:00
2009-08-22 13:07:09 +02:00
2009-04-01 08:59:13 -07:00
2009-04-07 08:44:06 -07:00
2009-06-02 09:53:22 -07:00
2009-09-14 17:39:12 -07:00
2009-11-07 13:10:46 +01:00
2009-09-15 09:50:48 -07:00
2009-06-16 14:29:30 -07:00
2009-09-09 14:19:11 -07:00
2009-03-20 10:47:49 -07:00
2009-09-15 09:39:44 -07:00
2009-08-14 15:00:53 +09:00
2009-09-22 15:42:01 +02:00
2009-10-23 09:35:02 +02:00
2009-07-13 08:01:47 +10:00
2009-03-26 18:14:15 +01:00
2009-09-24 15:38:57 -07:00
2009-05-26 21:16:25 -07:00
2009-05-11 14:13:10 +02:00
2009-04-24 08:54:21 +02:00
2009-07-22 00:28:39 +02:00
2009-08-23 00:04:44 +02:00
2009-09-14 20:27:00 +02:00
2009-09-22 07:17:49 -07:00
2009-09-22 07:17:47 -07:00
2009-10-04 15:05:10 -07:00
2009-06-24 16:58:48 -04:00
2009-07-30 17:49:15 +04:00
2009-03-13 16:09:12 -07:00
2009-03-26 18:14:14 +01:00
2009-06-18 13:04:04 -07:00
2009-07-29 19:10:36 -07:00
2009-10-04 03:23:17 +02:00
2009-12-02 09:55:33 +01:00
2009-09-23 07:39:41 -07:00
2009-06-18 13:03:51 -07:00
2009-03-30 15:22:01 +02:00
2009-06-11 21:36:12 -04:00
2009-03-26 02:18:35 +01:00
2009-09-22 07:17:24 -07:00
2009-06-16 19:47:30 -07:00
2009-09-27 11:39:25 -07:00
2009-06-11 08:51:08 -07:00
2009-09-19 08:53:22 +02:00
2009-04-14 18:41:15 +02:00
2009-10-05 21:02:02 +02:00
2009-10-15 11:17:17 +02:00
2009-08-23 19:13:02 -07:00
2009-06-24 08:17:06 -04:00
2009-06-24 08:17:06 -04:00
2009-06-11 21:35:58 -04:00
2009-06-18 13:03:46 -07:00
2009-05-17 11:45:45 -07:00
2009-09-24 07:20:57 -07:00
2009-10-01 16:11:13 -07:00
2009-09-01 12:48:21 -04:00
2009-09-04 19:42:22 -04:00
2009-09-24 07:53:22 -07:00
2009-05-09 10:49:41 -04:00
2009-04-17 20:37:21 -07:00
2009-04-02 19:04:51 -07:00
2009-04-01 08:59:24 -07:00
2009-09-09 03:42:23 -07:00
2009-09-15 02:44:17 -07:00
2009-07-31 12:28:45 +02:00
2009-12-02 17:32:40 +01:00
2009-06-03 09:14:45 -04:00
2009-04-19 10:47:45 -07:00
2009-09-24 07:21:04 -07:00
2009-03-26 18:14:15 +01:00
2009-09-15 11:37:33 +10:00
2009-09-24 07:47:35 -04:00
2009-09-19 13:13:19 -07:00
2009-09-30 21:46:59 +02:00
2009-04-08 14:33:38 -07:00
2009-06-22 11:32:24 -07:00
2009-05-08 23:22:26 +09:00
2009-09-19 13:13:30 -07:00
2009-07-26 11:17:01 -07:00
2009-08-28 19:57:33 -04:00
2009-08-28 19:57:30 -04:00
2009-08-24 19:52:38 +09:00
2009-05-03 17:57:17 +09:00
2009-09-15 09:50:49 -07:00
2009-04-13 15:04:29 -07:00
2009-09-24 07:21:01 -07:00
2009-10-30 12:25:12 -07:00
2009-06-13 08:58:43 +02:00
2009-06-15 15:50:49 +02:00
2009-08-06 11:36:25 +03:00
2009-04-21 19:40:00 -07:00
2009-09-14 20:19:06 +03:00
2009-09-24 09:34:40 +09:30
2009-04-28 01:53:11 -07:00
2009-04-27 02:45:02 -07:00
2009-10-05 00:24:36 -07:00
2009-03-27 12:18:56 -04:00
2009-08-31 18:08:51 +02:00
2009-06-10 11:48:14 +02:00
2009-08-31 18:08:51 +02:00
2009-05-12 11:11:48 +02:00
2009-06-12 23:04:12 +02:00
2009-10-29 07:39:25 -07:00
2009-04-10 15:48:52 +02:00
2009-03-26 18:14:14 +01:00
2009-06-12 21:32:33 +02:00
2009-09-24 07:53:22 -07:00
2009-09-16 11:50:05 +02:00
2009-07-28 14:19:20 +09:00
2009-04-02 19:05:01 -07:00
2009-09-23 09:21:05 -07:00
2009-09-24 07:21:04 -07:00
2009-07-06 13:57:03 -07:00
2009-09-18 09:48:52 -07:00
2009-09-01 18:25:07 -07:00
2009-09-02 01:03:43 -07:00
2009-03-27 16:58:22 -04:00
2009-04-06 11:14:03 +02:00
2009-06-13 12:00:26 +02:00
2009-09-24 07:20:56 -07:00
2009-08-30 22:26:34 +02:00
2009-03-27 12:59:54 +08:00
2009-03-26 18:14:14 +01:00
2009-06-16 19:47:27 -07:00
2009-07-05 19:16:11 -07:00
2009-10-14 15:02:34 +02:00
2009-10-24 11:07:51 +02:00
2009-09-24 07:21:00 -07:00
2009-09-24 07:20:57 -07:00
2009-09-15 09:50:47 -07:00
2009-09-27 13:35:16 -07:00
2009-08-04 13:46:30 -07:00
2009-09-19 13:13:35 -07:00
2009-06-19 08:08:50 +02:00
2009-03-02 11:06:49 +01:00
2009-09-23 07:39:48 -07:00
2009-03-24 16:38:24 -07:00
2009-07-29 19:10:39 -07:00
2009-06-12 18:01:45 +02:00
2009-03-24 16:20:34 -07:00
2009-09-23 06:46:23 -07:00
2009-09-23 06:46:39 -07:00
2009-03-26 18:14:14 +01:00
2009-09-23 18:13:10 -07:00
2009-08-26 12:39:29 +01:00
2009-09-24 09:57:08 -07:00
2009-09-19 00:18:36 -03:00
2009-03-30 12:43:15 -03:00
2009-10-22 16:39:28 +10:30
2009-10-22 16:39:28 +10:30
2009-10-22 16:39:30 +10:30
2009-09-23 07:39:29 -07:00
2009-10-22 16:39:28 +10:30
2009-09-23 22:26:32 +09:30
2009-10-22 16:39:28 +10:30
2009-06-12 22:16:37 +09:30
2009-07-30 16:03:46 +09:30
2009-10-22 16:39:28 +10:30
2009-09-23 22:26:31 +09:30
2009-06-16 19:47:52 -07:00
2009-08-14 15:00:52 +09:00
2009-09-22 07:17:30 -07:00
2009-09-19 13:13:25 -07:00
2009-09-19 13:13:26 -07:00
2009-06-18 13:03:58 -07:00
2009-09-15 16:51:30 +02:00
2009-05-28 18:02:32 -07:00
2009-07-15 08:53:39 -07:00
2009-09-04 20:20:58 +04:00
2009-09-23 03:49:27 +04:00
2009-10-14 09:16:42 -07:00
2009-09-24 07:21:04 -07:00
2009-09-10 10:11:22 +10:00
2009-03-26 18:14:14 +01:00
0cf55e1ec0