Peter Zijlstra 14358e6dda
lockdep: annotate dir vs file i_mutex ...
On Mon, 2007-09-24 at 22:13 -0400, Steven Rostedt wrote:
> The circular lock seems to be this:
>
> #1 :
>
> sys_mmap2: down_write(&mm->mmap_sem);
> nfs_revalidate_mapping: mutex_lock(&inode->i_mutex);
>
>
> #0 :
>
> vfs_readdir: mutex_lock(&inode->i_mutex);
> - during the readdir (filldir64), we take a user fault (missing page?)
> and call do_page_fault -
> do_page_fault: down_read(&mm->mmap_sem);
>
>
> So it does indeed look like a circular locking. Now the question is, "is
> this a bug?". Looking like the inode of #1 must be a file or something
> else that you can mmap and the inode of #0 seems it must be a directory.
> I would say "no".
>
> Now if you can readdir on a file or mmap a directory, then this could be
> an issue.
>
> Otherwise, I'd love to see someone teach lockdep about this issue! ;-)
Make a distinction between file and dir usage of i_mutex.
The inode should be complete and unused at unlock_new_inode(), re-init
i_mutex depending on its type.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl >
2007-10-14 01:38:33 +02:00
2007-08-23 10:13:45 -05:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-10-10 16:49:10 -07:00
2007-05-11 08:29:36 -07:00
2007-08-22 19:52:46 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-08-18 00:15:20 +00:00
2007-07-21 17:49:14 -07:00
2007-07-20 10:11:58 +09:00
2007-05-07 12:12:51 -07:00
2007-10-12 14:51:03 -07:00
2007-05-08 11:14:59 -07:00
2007-10-12 15:49:37 -07:00
2007-10-10 21:15:29 -07:00
2007-07-20 10:11:58 +09:00
2007-07-17 10:23:06 -07:00
2007-07-26 11:35:17 -07:00
2007-09-19 11:24:18 -07:00
2007-09-19 11:24:18 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-10-12 15:49:37 -07:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-10 08:04:13 +02:00
2007-07-20 10:11:58 +09:00
2007-08-31 01:42:23 -07:00
2007-07-31 15:39:41 -07:00
2007-10-11 22:11:12 +02:00
2007-07-20 10:11:58 +09:00
2007-10-13 14:43:54 +01:00
2007-10-14 12:41:52 -07:00
2007-10-09 12:38:26 -07:00
2007-07-20 10:11:58 +09:00
2007-07-31 15:39:41 -07:00
2007-09-28 15:36:42 -07:00
2007-09-10 18:57:47 -07:00
2007-07-16 09:05:52 -07:00
2007-10-12 09:16:30 -07:00
2007-10-12 15:49:37 -07:00
2007-07-20 10:11:58 +09:00
2007-10-14 12:41:51 -07:00
2007-10-10 16:54:58 -07:00
2007-07-20 10:11:58 +09:00
2007-07-31 15:39:36 -07:00
2007-09-11 17:21:19 -07:00
2007-07-20 10:11:58 +09:00
2007-10-14 12:41:52 -07:00
2007-10-12 14:51:12 -07:00
2007-07-20 10:11:58 +09:00
2007-08-31 01:42:22 -07:00
2007-09-25 08:51:04 -07:00
2007-10-12 00:29:50 -07:00
2007-10-08 12:58:14 -07:00
2007-07-17 11:50:26 -07:00
2007-07-17 12:00:03 -07:00
2007-07-10 08:04:15 +02:00
2007-07-19 10:04:47 -07:00
2007-09-19 15:12:19 +10:00
2007-05-08 11:15:07 -07:00
2007-10-03 23:43:57 +08:00
2007-07-19 10:04:45 -07:00
2007-07-19 10:04:45 -07:00
2007-10-10 09:25:57 +02:00
2007-10-10 09:25:57 +02:00
2007-10-10 09:25:57 +02:00
2007-07-19 10:04:43 -07:00
2007-10-11 19:40:14 -07:00
2007-07-19 10:04:45 -07:00
2007-07-20 10:11:58 +09:00
2007-07-29 17:09:29 -07:00
2007-10-10 09:25:57 +02:00
2007-07-20 10:11:58 +09:00
2007-07-20 10:11:58 +09:00
2007-07-16 09:05:36 -07:00
2007-05-18 13:09:34 -07:00
2007-07-20 10:11:58 +09:00
2007-09-20 13:19:59 -07:00
2007-07-20 10:11:58 +09:00
2007-05-21 09:18:19 -07:00
2007-05-08 11:15:07 -07:00
2007-05-08 11:15:01 -07:00
2007-10-10 09:25:57 +02:00
2007-07-17 12:00:03 -07:00
2007-10-14 01:38:33 +02:00
2007-07-20 10:11:58 +09:00
2007-05-08 11:15:11 -07:00
2007-05-08 11:15:09 -07:00
2007-07-16 09:05:48 -07:00
2007-10-13 14:43:54 +01:00
2007-05-21 14:34:00 +09:00
2007-05-09 06:44:57 +02:00
2007-09-11 17:21:27 -07:00
2007-05-11 08:29:36 -07:00
2007-07-20 10:11:58 +09:00
2007-10-10 09:25:57 +02:00
2007-07-19 10:04:45 -07:00
2007-07-20 10:11:58 +09:00
2007-07-19 10:04:45 -07:00
2007-07-31 15:39:42 -07:00
2007-07-27 08:08:51 +02:00
2007-05-08 11:15:11 -07:00
2007-07-27 15:40:13 -07:00
2007-07-10 08:04:15 +02:00
2007-05-08 11:15:09 -07:00
2007-09-11 17:21:20 -07:00
2007-10-10 16:55:33 -07:00
2007-09-20 13:19:59 -07:00
2007-10-01 13:17:28 -07:00
2007-05-08 11:15:07 -07:00
2007-07-16 09:05:46 -07:00
2007-06-28 11:38:30 -07:00
2007-07-26 11:35:17 -07:00
2007-07-17 12:00:03 -07:00
2007-07-17 12:00:03 -07:00
14358e6dda