Jiri Slaby 24d406a6bf
TTY: pty, fix pty counting ...
tty_operations->remove is normally called like:
queue_release_one_tty
->tty_shutdown
->tty_driver_remove_tty
->tty_operations->remove
However tty_shutdown() is called from queue_release_one_tty() only if
tty_operations->shutdown is NULL. But for pty, it is not.
pty_unix98_shutdown() is used there as ->shutdown.
So tty_operations->remove of pty (i.e. pty_unix98_remove()) is never
called. This results in invalid pty_count. I.e. what can be seen in
/proc/sys/kernel/pty/nr.
I see this was already reported at:
https://lkml.org/lkml/2009/11/5/370
But it was not fixed since then.
This patch is kind of a hackish way. The problem lies in ->install. We
allocate there another tty (so-called tty->link). So ->install is
called once, but ->remove twice, for both tty and tty->link. The fix
here is to count both tty and tty->link and divide the count by 2 for
user.
And to have ->remove called, let's make tty_driver_remove_tty() global
and call that from pty_unix98_shutdown() (tty_operations->shutdown).
While at it, let's document that when ->shutdown is defined,
tty_shutdown() is not called.
Signed-off-by: Jiri Slaby <jslaby@suse.cz >
Cc: Alan Cox <alan@linux.intel.com >
Cc: "H. Peter Anvin" <hpa@zytor.com >
Cc: stable <stable@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2011-08-23 10:10:38 -07:00
2011-07-27 20:43:21 +05:30
2011-07-22 09:51:12 -04:00
2011-07-26 13:38:50 -07:00
2011-07-27 17:52:58 -03:00
2011-07-17 21:48:22 +02:00
2011-07-06 21:23:54 -07:00
2011-08-03 14:25:22 -10:00
2011-07-26 16:49:47 -07:00
2011-07-20 17:21:16 -04:00
2011-07-22 13:09:55 -07:00
2011-07-21 12:39:35 -07:00
2011-07-15 18:58:42 -04:00
2011-07-30 08:57:57 -10:00
2011-07-08 17:01:58 +04:00
2011-07-28 11:31:47 +10:00
2011-07-15 13:54:17 -06:00
2011-07-25 13:56:39 -07:00
2011-07-27 13:23:02 -07:00
2011-07-14 14:45:59 -07:00
2011-07-08 15:30:55 -07:00
2011-08-03 21:53:27 -10:00
2011-07-22 08:25:37 -07:00
2011-07-26 16:49:47 -07:00
2011-07-20 20:47:43 -04:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-06-30 13:31:57 +02:00
2011-07-26 16:49:47 -07:00
2011-07-20 01:43:10 -04:00
2011-07-26 16:49:47 -07:00
2011-08-03 11:30:42 -04:00
2011-07-23 20:44:25 +02:00
2011-07-26 16:49:47 -07:00
2011-07-08 22:21:58 +02:00
2011-07-22 17:05:15 -07:00
2011-07-18 21:38:33 +02:00
2011-07-15 18:58:42 -04:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-25 20:57:14 -07:00
2011-08-03 19:06:37 -04:00
2011-07-26 16:49:44 -07:00
2011-08-07 13:42:35 -07:00
2011-07-26 16:49:47 -07:00
2011-08-06 22:12:37 -07:00
2011-07-06 14:44:42 -07:00
2011-07-25 20:57:16 -07:00
2011-08-06 22:52:40 -07:00
2011-07-05 23:42:17 -07:00
2011-07-26 16:49:47 -07:00
2011-08-02 12:32:04 +01:00
2011-07-26 16:49:47 -07:00
2011-08-02 12:32:06 +01:00
2011-08-02 12:32:04 +01:00
2011-07-26 16:49:45 -07:00
2011-06-30 09:23:45 +02:00
2011-07-26 16:49:47 -07:00
2011-07-25 20:57:16 -07:00
2011-08-01 13:40:51 -10:00
2011-07-13 02:29:59 -07:00
2011-06-30 22:32:49 -07:00
2011-07-26 11:34:40 -07:00
2011-08-03 14:25:20 -10:00
2011-07-20 20:47:59 -04:00
2011-07-07 08:18:18 +02:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-16 07:24:32 +02:00
2011-07-26 16:49:47 -07:00
2011-08-06 22:53:23 -07:00
2011-07-07 13:21:56 -07:00
2011-07-08 00:21:27 -05:00
2011-07-26 16:49:47 -07:00
2011-07-14 16:36:53 -04:00
2011-07-11 10:12:59 -04:00
2011-08-03 11:15:57 -04:00
2011-07-25 14:30:23 -04:00
2011-07-01 16:17:47 +02:00
2011-08-03 14:25:21 -10:00
2011-07-01 15:34:45 -07:00
2011-07-25 20:57:07 -07:00
2011-07-01 11:06:38 +02:00
2011-07-10 05:27:15 -06:00
2011-07-01 10:37:15 +02:00
2011-08-03 14:25:20 -10:00
2011-07-19 16:49:54 -04:00
2011-07-17 12:33:22 -07:00
2011-07-06 01:56:38 -07:00
2011-07-21 13:47:58 -07:00
2011-07-27 22:39:30 -07:00
2011-07-21 13:47:54 -07:00
2011-07-12 08:35:10 +02:00
2011-08-05 14:45:41 -04:00
2011-07-26 16:49:47 -07:00
2011-07-12 14:24:35 +02:00
2011-07-31 14:30:59 -10:00
2011-07-26 16:49:44 -07:00
2011-07-28 01:32:04 -06:00
2011-07-28 01:32:04 -06:00
2011-06-29 16:43:06 -05:00
2011-07-10 22:05:08 -04:00
2011-07-25 17:24:47 +02:00
2011-07-26 16:49:47 -07:00
2011-07-08 00:21:27 -05:00
2011-07-29 21:53:30 +02:00
2011-07-26 16:49:47 -07:00
2011-07-27 13:21:40 -07:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-24 11:50:34 +03:00
2011-07-12 13:16:57 +03:00
2011-07-25 20:57:15 -07:00
2011-07-22 14:39:48 +09:30
2011-07-23 17:57:36 -04:00
2011-08-03 11:15:56 -04:00
2011-08-03 14:25:24 -10:00
2011-07-25 20:57:08 -07:00
2011-07-12 11:08:01 +10:00
2011-07-18 15:17:01 +03:00
2011-08-03 11:30:42 -04:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-20 20:47:50 -04:00
2011-07-24 22:06:04 +09:30
2011-07-24 22:06:04 +09:30
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-20 01:44:14 -04:00
2011-07-28 05:58:19 -07:00
2011-07-03 20:02:07 -07:00
2011-07-05 15:26:58 -04:00
2011-07-31 12:18:15 -04:00
2011-07-31 14:27:04 -10:00
2011-08-01 13:48:31 -10:00
2011-07-15 09:12:22 -04:00
2011-08-06 22:56:03 -07:00
2011-07-31 12:18:16 -04:00
2011-07-25 13:56:39 -07:00
2011-07-26 16:49:43 -07:00
2011-07-25 20:57:15 -07:00
2011-07-20 01:44:07 -04:00
2011-07-18 16:37:45 -06:00
2011-08-04 11:26:24 +01:00
2011-07-28 16:19:22 -06:00
2011-07-28 01:32:04 -06:00
2011-07-27 09:30:56 +08:00
2011-08-04 11:26:24 +01:00
2011-07-25 20:57:09 -07:00
2011-07-15 23:58:18 +02:00
2011-07-26 16:49:47 -07:00
2011-07-30 08:21:48 -10:00
2011-07-25 20:57:10 -07:00
2011-08-04 16:43:43 -10:00
2011-07-29 23:35:05 -07:00
2011-07-26 16:49:47 -07:00
2011-07-27 09:31:02 +08:00
2011-07-08 00:21:35 -05:00
2011-07-08 14:02:53 +02:00
2011-07-14 20:59:07 +02:00
2011-07-12 11:17:09 +02:00
2011-07-02 14:29:55 +02:00
2011-07-12 13:40:29 -04:00
2011-07-25 20:57:09 -07:00
2011-08-03 00:58:42 -04:00
2011-07-27 12:50:45 -07:00
2011-07-22 16:14:29 -07:00
2011-07-01 15:39:38 -07:00
2011-07-17 20:23:52 +02:00
2011-07-26 16:49:47 -07:00
2011-08-03 14:25:24 -10:00
2011-07-26 16:49:46 -07:00
2011-08-06 18:33:19 -07:00
2011-07-20 14:10:20 -07:00
2011-07-25 20:57:14 -07:00
2011-07-23 07:56:59 +01:00
2011-07-25 14:30:23 -04:00
2011-07-25 20:57:17 -07:00
2011-07-25 14:30:23 -04:00
2011-07-08 14:02:53 +02:00
2011-07-25 13:56:39 -07:00
2011-07-26 16:49:47 -07:00
2011-07-25 10:33:36 -07:00
2011-07-18 11:06:03 -07:00
2011-07-20 01:43:29 -04:00
2011-07-26 16:49:47 -07:00
2011-07-20 20:47:50 -04:00
2011-07-11 15:07:25 +09:00
2011-07-30 08:44:19 -10:00
2011-08-03 14:25:24 -10:00
2011-07-20 20:47:10 -04:00
2011-07-26 16:49:47 -07:00
2011-07-20 20:27:56 +03:00
2011-07-07 21:04:12 +03:00
2011-07-30 08:21:48 -10:00
2011-07-05 15:26:58 -04:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-25 20:57:11 -07:00
2011-07-21 15:29:16 -07:00
2011-07-25 13:56:39 -07:00
2011-07-25 20:57:15 -07:00
2011-07-26 16:49:47 -07:00
2011-08-03 14:25:22 -10:00
2011-07-26 16:49:47 -07:00
2011-08-02 14:51:57 -04:00
2011-08-23 10:10:38 -07:00
2011-08-23 10:10:38 -07:00
2011-07-27 17:55:40 -03:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:45 -07:00
2011-07-25 20:57:15 -07:00
2011-07-28 08:01:18 +00:00
2011-07-04 19:31:38 -07:00
2011-07-26 16:49:47 -07:00
2011-07-09 22:09:03 -07:00
24d406a6bf