This repository has been archived on 2026-03-14. You can view files and clone it, but cannot push or open issues or pull requests.
Files
ubports_kernel_google_msm/include/linux
Masami Hiramatsu 30736a4d43 coredump: pass mm->flags as a coredump parameter for consistency
Pass mm->flags as a coredump parameter for consistency.

 ---
1787         if (mm->core_state || !get_dumpable(mm)) {  <- (1)
1788                 up_write(&mm->mmap_sem);
1789                 put_cred(cred);
1790                 goto fail;
1791         }
1792
[...]
1798         if (get_dumpable(mm) == 2) {    /* Setuid core dump mode */ <-(2)
1799                 flag = O_EXCL;          /* Stop rewrite attacks */
1800                 cred->fsuid = 0;        /* Dump root private */
1801         }
 ---

Since dumpable bits are not protected by lock, there is a chance to change
these bits between (1) and (2).

To solve this issue, this patch copies mm->flags to
coredump_params.mm_flags at the beginning of do_coredump() and uses it
instead of get_dumpable() while dumping core.

This copy is also passed to binfmt->core_dump, since elf*_core_dump() uses
dump_filter bits in mm->flags.

[akpm@linux-foundation.org: fix merge]
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2010-03-06 11:26:46 -08:00
..
2010-02-28 23:55:20 -08:00
2009-10-27 16:47:55 -04:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-12-16 07:20:13 -08:00
2009-09-08 17:42:50 -07:00
2010-03-01 15:11:32 -05:00
2009-11-08 20:57:03 -08:00
2010-02-05 07:35:05 -08:00
2009-07-12 12:22:34 -07:00
2009-09-18 09:48:52 -07:00
2009-12-10 23:52:01 +00:00
2009-11-04 09:50:58 -08:00
2009-10-01 21:17:49 +02:00
2009-09-14 17:41:42 -07:00
2009-12-15 08:53:33 -08:00
2009-11-04 09:50:58 -08:00
2009-12-23 13:33:54 +01:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-09-01 01:13:31 -07:00
2009-12-14 23:55:34 +01:00
2010-03-02 12:23:42 +01:00
2010-03-02 12:23:49 +01:00
2010-01-19 01:52:36 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2010-02-18 14:08:38 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2010-02-17 16:35:17 -08:00
2009-11-04 09:50:58 -08:00
2010-02-02 07:32:29 -08:00
2010-01-11 16:28:01 -08:00
2010-02-22 16:17:00 -08:00
2009-11-04 09:50:58 -08:00
2009-09-26 10:17:19 -07:00
2009-10-18 18:52:53 -07:00
2009-08-29 15:53:00 +02:00
2009-09-26 10:17:19 -07:00
2009-12-16 06:56:12 -08:00
2009-06-23 20:21:39 +01:00
2009-07-30 16:03:45 +09:30
2009-12-15 08:53:36 -08:00
2009-12-26 20:40:34 -08:00
2010-02-03 17:39:50 +11:00
2009-10-01 21:17:49 +02:00
2010-02-19 03:35:12 -05:00
2009-09-22 07:17:35 -07:00
2009-12-15 08:53:20 -08:00
2010-03-06 11:26:26 -08:00
2009-12-12 13:08:15 +01:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2010-02-03 20:32:28 -08:00
2009-11-04 09:50:58 -08:00
2010-02-19 15:52:40 -05:00
2010-02-14 07:13:47 -07:00
2010-01-05 09:17:33 +09:00
2010-02-04 10:23:02 -08:00
2009-11-04 09:50:58 -08:00
2009-11-04 09:50:58 -08:00
2009-10-04 15:05:10 -07:00
2009-12-03 11:43:23 +00:00
2009-07-29 19:10:36 -07:00
2009-12-02 09:55:33 +01:00
2009-09-23 07:39:41 -07:00
2010-03-05 00:20:31 +01:00
2010-02-10 17:47:17 -08:00
2009-10-30 15:06:37 -07:00
2009-06-24 08:17:06 -04:00
2009-11-04 09:50:58 -08:00
2010-03-06 11:26:24 -08:00
2010-01-21 23:55:25 -08:00
2009-08-28 19:57:30 -04:00
2010-02-16 13:38:56 +09:00
2009-11-30 12:02:53 +09:00
2010-03-02 03:05:05 -08:00
2009-12-16 22:32:29 -05:00
2010-01-14 22:38:09 -05:00
2009-12-15 08:53:16 -08:00
2009-07-06 13:57:03 -07:00
2010-02-18 15:43:09 -08:00
2009-11-13 20:46:24 +01:00
2009-08-30 22:26:34 +02:00
2009-10-29 11:17:40 +11:00
2009-11-10 20:54:38 -08:00
2010-03-02 14:54:59 -08:00
2009-09-23 18:13:10 -07:00
2009-08-26 12:39:29 +01:00
2010-03-05 15:04:41 -06:00
2009-09-23 22:26:32 +09:30
2010-01-05 09:17:33 +09:00
2009-09-15 16:51:30 +02:00
2009-12-16 12:16:49 -05:00