This repository has been archived on 2026-03-14. You can view files and clone it, but cannot push or open issues or pull requests.
Files
ubports_kernel_google_msm/include/linux
Trond Myklebust bf294b41ce SUNRPC: Close a race in __rpc_wait_for_completion_task()
Although they run as rpciod background tasks, under normal operation
(i.e. no SIGKILL), functions like nfs_sillyrename(), nfs4_proc_unlck()
and nfs4_do_close() want to be fully synchronous. This means that when we
exit, we want all references to the rpc_task to be gone, and we want
any dentry references etc. held by that task to be released.

For this reason these functions call __rpc_wait_for_completion_task(),
followed by rpc_put_task() in the expectation that the latter will be
releasing the last reference to the rpc_task, and thus ensuring that the
callback_ops->rpc_release() has been called synchronously.

This patch fixes a race which exists due to the fact that
rpciod calls rpc_complete_task() (in order to wake up the callers of
__rpc_wait_for_completion_task()) and then subsequently calls
rpc_put_task() without ensuring that these two steps are done atomically.

In order to avoid adding new spin locks, the patch uses the existing
waitqueue spin lock to order the rpc_task reference count releases between
the waiting process and rpciod.
The common case where nobody is waiting for completion is optimised for by
checking if the RPC_TASK_ASYNC flag is cleared and/or if the rpc_task
reference count is 1: in those cases we drop trying to grab the spin lock,
and immediately free up the rpc_task.

Those few processes that need to put the rpc_task from inside an
asynchronous context and that do not care about ordering are given a new
helper: rpc_put_task_async().

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
2011-03-10 15:04:52 -05:00
..
2011-03-04 12:24:31 -08:00
2010-08-12 06:38:24 +10:00
2010-03-12 15:53:10 -08:00
2011-01-20 18:30:17 -08:00
2010-10-15 21:18:59 +02:00
2011-01-20 18:30:17 -08:00
2010-11-23 20:14:46 +00:00
2010-05-27 09:12:53 -07:00
2011-01-10 08:51:44 -08:00
2011-01-15 20:07:45 -05:00
2011-01-13 08:03:12 -08:00
2010-11-10 14:54:09 +01:00
2010-11-10 14:54:09 +01:00
2010-12-13 16:11:13 -08:00
2010-06-24 21:30:09 -07:00
2010-10-25 21:18:20 -04:00
2010-11-29 08:35:12 +11:00
2010-12-16 17:53:38 +01:00
2010-11-01 15:38:34 -04:00
2010-10-25 08:02:40 -07:00
2010-08-19 17:18:00 -07:00
2011-01-10 08:51:44 -08:00
2010-05-19 22:41:57 -04:00
2010-05-10 16:08:01 -07:00
2010-08-04 11:00:45 +02:00
2010-10-22 15:55:22 +02:00
2010-10-21 14:47:59 +02:00
2011-01-12 20:16:43 -05:00
2010-08-19 17:18:03 -07:00
2011-01-17 03:26:26 -05:00
2010-12-08 10:30:34 -08:00
2011-01-10 08:51:44 -08:00
2011-01-07 17:50:27 +11:00
2011-01-07 17:50:23 +11:00
2010-12-07 20:16:56 +01:00
2011-03-04 17:53:39 -08:00
2010-10-25 14:11:37 -07:00
2010-05-21 09:34:29 -07:00
2011-01-10 07:38:53 -08:00
2010-10-12 16:53:37 +02:00
2010-08-11 09:23:22 +02:00
2010-11-15 22:40:38 +01:00
2011-01-10 22:11:23 +01:00
2010-06-16 18:08:13 +02:00
2010-06-03 03:21:52 -07:00
2010-11-16 10:58:30 -08:00
2010-09-21 18:04:47 -07:00
2010-08-29 21:57:55 -07:00
2010-08-19 17:16:23 -07:00
2010-10-26 16:52:08 -07:00
2010-08-09 20:45:05 -07:00
2010-03-12 15:52:40 -08:00
2010-11-24 11:16:42 -08:00
2011-01-21 11:55:31 +01:00
2010-10-07 14:08:55 +01:00
2010-06-03 03:21:52 -07:00
2010-08-10 11:49:21 -07:00
2010-12-09 20:17:07 -08:00
2010-08-12 11:27:58 +02:00
2010-10-22 15:34:12 -05:00
2011-01-13 17:32:31 -08:00
2011-02-01 08:23:22 +10:00
2010-08-19 17:18:00 -07:00
2011-01-13 17:32:47 -08:00
2011-02-13 16:54:24 -08:00
2011-01-24 14:45:11 +10:30
2010-09-09 18:57:24 -07:00
2010-12-22 10:27:53 +01:00
2010-05-14 15:09:32 -04:00
2010-04-03 14:56:05 -07:00
2010-11-12 07:55:32 -08:00
2011-01-14 13:12:45 +00:00
2010-06-16 18:03:15 +02:00
2010-12-06 11:03:46 -08:00
2010-06-03 03:21:52 -07:00
2011-01-13 17:32:41 -08:00
2011-01-13 17:32:46 -08:00
2011-01-13 17:32:43 -08:00
2011-01-16 13:47:07 -05:00
2010-10-12 16:53:34 +02:00
2011-01-13 21:44:34 -08:00
2010-10-07 18:48:49 -04:00
2011-01-10 15:40:52 -05:00
2010-08-19 17:18:02 -07:00
2010-07-05 16:14:52 -06:00
2011-01-13 17:32:43 -08:00
2011-01-16 13:47:07 -05:00
2010-12-16 11:36:43 +01:00
2010-10-24 15:07:11 -07:00
2010-08-21 23:40:14 -07:00
2010-07-19 01:58:48 +02:00
2010-07-19 01:58:48 +02:00
2010-12-10 15:06:43 +01:00
2010-08-04 21:53:17 -07:00
2011-01-13 08:03:21 -08:00
2010-10-29 04:16:31 -04:00
2011-01-14 02:36:43 +00:00
2010-09-08 18:16:55 -07:00
2010-03-12 15:52:44 -08:00
2010-08-09 16:47:27 -04:00
2010-11-15 13:24:06 -05:00
2011-01-13 08:03:18 -08:00
2011-01-13 17:32:42 -08:00
2010-05-11 10:09:47 +02:00
2010-03-12 15:53:10 -08:00
2010-06-03 03:21:52 -07:00
2010-10-30 12:12:50 +02:00
2011-01-07 17:50:27 +11:00
2011-01-13 08:03:19 -08:00
2010-03-12 15:52:44 -08:00
2010-10-27 17:28:36 +01:00
2010-10-07 14:08:55 +01:00
2010-08-09 16:48:44 -04:00
2011-01-13 17:32:42 -08:00
2010-05-15 23:28:39 -07:00
2010-08-30 13:23:33 -07:00
2011-02-28 18:00:31 -08:00
2010-03-25 17:18:43 -07:00
2011-01-13 08:03:20 -08:00
2010-09-09 20:41:20 +02:00
2010-11-29 08:55:25 +11:00
2010-11-29 08:55:22 +11:00
2010-10-26 16:52:03 -07:00
2010-12-20 09:37:33 +01:00
2010-12-16 10:05:06 -08:00
2010-05-19 22:40:47 -04:00
2011-01-24 14:45:11 +10:30
2010-05-19 22:15:46 +09:30
2010-11-15 13:25:02 -05:00
2011-01-13 08:03:24 -08:00
2010-04-06 20:35:58 +04:00