Miklos Szeredi 4ed5e82fe7
vfs: protect remounting superblock read-only ...
Currently remouting superblock read-only is racy in a major way.
With the per mount read-only infrastructure it is now possible to
prevent most races, which this patch attempts.
Before starting the remount read-only, iterate through all mounts
belonging to the superblock and if none of them have any pending
writes, set sb->s_readonly_remount. This indicates that remount is in
progress and no further write requests are allowed. If the remount
succeeds set MS_RDONLY and reset s_readonly_remount.
If the remounting is unsuccessful just reset s_readonly_remount.
This can result in transient EROFS errors, despite the fact the
remount failed. Unfortunately hodling off writes is difficult as
remount itself may touch the filesystem (e.g. through load_nls())
which would deadlock.
A later patch deals with delayed writes due to nlink going to zero.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz >
Tested-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2012-01-06 23:20:12 -05:00
2011-11-04 18:02:25 -07:00
2011-10-31 19:32:32 -04:00
2011-10-17 19:22:46 -04:00
2011-11-11 09:50:19 -08:00
2011-11-03 09:40:51 -07:00
2011-10-18 21:26:55 -07:00
2011-11-23 14:03:52 +00:00
2011-11-01 10:51:38 -07:00
2011-12-10 16:18:35 -05:00
2011-11-07 09:11:16 -08:00
2011-11-01 09:19:52 +01:00
2011-11-09 15:07:40 +01:00
2011-10-31 17:30:55 -07:00
2011-11-06 19:44:47 -08:00
2011-10-31 17:30:54 -07:00
2011-10-31 19:32:32 -04:00
2012-01-03 22:55:04 -05:00
2011-10-31 15:42:54 -07:00
2011-10-31 19:32:32 -04:00
2011-11-02 16:07:03 -07:00
2011-10-26 15:43:26 -04:00
2011-10-26 15:43:25 -04:00
2012-01-03 22:55:17 -05:00
2011-10-31 00:33:36 +08:00
2011-11-16 09:21:50 +01:00
2011-10-24 16:11:30 +02:00
2011-11-23 10:59:13 +01:00
2011-10-31 17:30:54 -07:00
2011-10-17 19:22:46 -04:00
2011-10-20 18:21:36 -04:00
2012-01-03 22:55:03 -05:00
2011-09-27 09:25:02 +01:00
2011-10-13 14:36:58 +01:00
2011-10-03 09:34:16 +02:00
2011-12-19 11:41:40 +01:00
2011-09-28 13:41:50 -04:00
2011-10-31 17:30:49 -07:00
2012-01-03 22:55:19 -05:00
2012-01-03 22:54:57 -05:00
2011-09-23 12:05:29 +05:30
2011-11-04 22:28:09 +01:00
2011-11-07 10:13:52 -08:00
2011-10-30 15:16:41 +01:00
2011-11-06 19:44:47 -08:00
2011-10-21 14:24:07 +02:00
2011-12-06 23:57:18 -05:00
2012-01-03 22:54:56 -05:00
2011-11-07 23:54:53 +01:00
2011-10-31 19:32:26 -04:00
2011-10-31 20:19:04 +00:00
2012-01-03 22:54:55 -05:00
2011-10-31 20:19:04 +00:00
2011-10-31 20:18:58 +00:00
2011-10-31 20:21:24 +00:00
2011-12-16 08:49:57 -08:00
2011-11-06 17:12:03 -08:00
2011-11-06 19:44:47 -08:00
2011-10-31 17:30:44 -07:00
2011-10-04 13:08:18 -07:00
2011-10-31 17:30:54 -07:00
2011-10-31 15:10:04 -02:00
2011-10-19 14:33:08 +02:00
2011-10-30 15:16:43 +01:00
2011-11-04 18:37:23 -04:00
2011-10-31 09:20:11 -04:00
2011-10-10 18:25:59 +02:00
2012-01-03 22:54:58 -05:00
2011-10-19 19:35:51 -04:00
2011-10-31 19:32:32 -04:00
2011-11-04 22:28:15 +01:00
2012-01-06 23:20:12 -05:00
2011-10-31 17:30:54 -07:00
2011-10-05 01:10:12 +00:00
2011-12-05 13:28:45 -05:00
2011-10-31 19:32:32 -04:00
2011-11-06 19:44:47 -08:00
2012-01-03 22:54:55 -05:00
2011-10-24 16:04:06 +02:00
2011-10-31 19:32:32 -04:00
2011-10-31 17:30:48 -07:00
2011-11-19 06:15:59 -05:00
2011-11-08 09:28:27 +02:00
2011-10-11 09:51:22 -06:00
2011-10-29 09:37:09 +01:00
2011-11-23 11:33:07 +01:00
2012-01-03 22:54:56 -05:00
2011-09-30 15:57:07 -04:00
2011-10-11 15:35:42 -04:00
2011-10-16 13:15:38 -07:00
2011-10-21 02:53:07 -04:00
2011-10-03 14:03:48 -04:00
2011-10-30 04:43:30 -04:00
2011-11-14 01:08:49 -05:00
2011-12-05 16:50:24 -08:00
2011-10-28 14:25:01 -07:00
2011-10-26 16:17:32 +02:00
2011-10-17 11:42:49 +02:00
2011-10-28 05:54:23 -07:00
2011-10-21 14:38:55 +02:00
2011-09-20 14:50:00 -04:00
2012-01-03 22:55:17 -05:00
2011-10-31 19:32:32 -04:00
2011-10-31 19:32:32 -04:00
2011-10-04 12:43:49 +02:00
2011-10-31 19:32:35 -04:00
2011-10-31 19:32:35 -04:00
2011-10-31 14:03:23 +01:00
2012-01-03 22:54:55 -05:00
2011-09-27 18:08:04 +02:00
2011-10-27 04:38:18 -04:00
2011-10-27 04:38:18 -04:00
2011-10-27 04:38:18 -04:00
2011-09-21 10:28:51 +02:00
2011-10-25 11:55:15 -07:00
2011-10-31 17:30:54 -07:00
2011-10-31 17:30:54 -07:00
2011-11-07 07:54:42 +10:30
2011-10-31 17:46:07 -07:00
2011-10-31 17:30:54 -07:00
2011-10-31 17:30:54 -07:00
2011-10-31 17:30:54 -07:00
2011-09-25 19:52:59 +03:00
2011-12-26 13:27:44 +02:00
2011-12-22 02:02:20 -05:00
2011-10-31 17:30:54 -07:00
2011-10-31 17:30:52 -07:00
2011-10-31 17:30:57 -07:00
2011-09-28 21:36:37 -07:00
2011-12-12 22:06:55 -08:00
2011-11-04 17:22:14 -07:00
2011-11-02 16:06:59 -07:00
2011-10-31 19:32:32 -04:00
2011-10-31 17:30:47 -07:00
2011-11-02 16:07:00 -07:00
2012-01-03 22:55:15 -05:00
2011-11-02 16:06:57 -07:00
2011-12-09 07:50:27 -08:00
2011-10-31 17:30:54 -07:00
2011-10-31 17:30:47 -07:00
2012-01-03 22:57:13 -05:00
2011-10-31 09:20:11 -04:00
2011-10-31 09:20:11 -04:00
2012-01-03 22:57:12 -05:00
2011-11-02 12:53:42 +01:00
2011-10-19 17:00:35 -04:00
2011-11-28 18:07:29 -05:00
2011-11-01 09:24:41 -07:00
2011-09-20 14:43:49 -04:00
2011-10-19 11:52:12 -04:00
2012-01-03 22:52:34 -05:00
2011-10-19 13:58:38 -07:00
2011-11-04 16:39:04 -04:00
2011-10-14 14:48:23 -04:00
2011-10-31 14:03:22 +01:00
2011-10-31 19:32:27 -04:00
2011-11-06 19:44:47 -08:00
2011-10-31 17:30:45 -07:00
2011-11-04 22:28:13 +01:00
2011-10-31 19:32:32 -04:00
2011-12-05 18:13:11 +01:00
2011-10-14 09:05:35 -07:00
2011-10-31 10:23:57 -07:00
2011-10-31 10:23:57 -07:00
2011-12-05 09:33:03 +01:00
2011-10-24 02:54:50 -04:00
2011-11-22 16:37:01 -05:00
2011-10-29 07:28:36 -07:00
2011-09-26 20:22:02 +02:00
2011-10-04 21:54:26 +02:00
2011-11-17 21:39:33 +01:00
2011-11-28 22:14:55 +01:00
2011-11-02 16:07:02 -07:00
2011-10-31 17:30:54 -07:00
2012-01-03 22:54:56 -05:00
2011-11-17 12:58:07 -08:00
2011-09-29 00:32:03 -04:00
2011-10-31 17:30:54 -07:00
2012-01-03 22:55:07 -05:00
2011-10-28 05:29:07 -07:00
2011-09-28 21:38:35 -07:00
2011-09-28 21:38:20 -07:00
2011-09-28 21:36:42 -07:00
2011-10-31 19:32:32 -04:00
2012-01-03 22:55:00 -05:00
2012-01-03 22:54:56 -05:00
2011-10-03 15:19:19 -04:00
2011-11-02 16:07:01 -07:00
2011-11-17 20:49:06 +08:00
2012-01-06 23:16:53 -05:00
2011-11-02 16:07:01 -07:00
2012-01-03 22:52:40 -05:00
2011-09-22 15:50:38 -07:00
2011-09-22 15:50:38 -07:00
2011-11-11 16:16:25 +09:00
2011-11-15 12:13:44 -08:00
2011-10-31 19:32:32 -04:00
2011-11-11 16:11:41 +09:00
2011-09-28 13:41:51 -04:00
2011-11-11 16:45:35 +09:00
2012-01-03 22:55:07 -05:00
2011-12-09 07:50:27 -08:00
2011-11-29 11:59:50 +00:00
2011-11-01 00:55:48 -04:00
2011-09-27 23:03:30 +03:00
2011-10-31 19:32:28 -04:00
2011-10-31 17:30:47 -07:00
2011-10-16 23:28:51 +02:00
2011-10-31 17:30:44 -07:00
2012-01-03 22:55:19 -05:00
2012-01-03 22:55:12 -05:00
2011-10-31 19:32:24 -04:00
2012-01-03 22:54:56 -05:00
2011-10-03 14:01:21 -04:00
2011-10-31 19:32:32 -04:00
2011-09-20 15:53:21 +10:00
2011-09-19 11:35:58 -04:00
2011-10-31 17:30:54 -07:00
2011-10-26 15:11:09 +02:00
2012-01-03 22:55:17 -05:00
2011-10-12 21:13:11 -07:00
2011-10-31 19:32:32 -04:00
2012-01-03 22:54:55 -05:00
2011-11-02 16:07:02 -07:00
2011-10-31 19:32:31 -04:00
2011-10-31 19:32:23 -04:00
2011-11-03 18:29:09 -02:00
2011-11-24 13:04:48 +10:30
2011-11-24 13:04:47 +10:30
2011-11-02 11:40:59 +10:30
2011-11-02 11:40:59 +10:30
2011-10-31 19:32:32 -04:00
2011-11-16 12:13:08 -05:00
2011-10-31 00:33:36 +08:00
4ed5e82fe7