Denis V. Lunev
59b7435149
proc: introduce proc_create_data to setup de->data
This set of patches fixes an proc ->open'less usage due to ->proc_fops flip in
the most part of the kernel code. The original OOPS is described in the
commit 2d3a4e3666:
Typical PDE creation code looks like:
pde = create_proc_entry("foo", 0, NULL);
if (pde)
pde->proc_fops = &foo_proc_fops;
Notice that PDE is first created, only then ->proc_fops is set up to
final value. This is a problem because right after creation
a) PDE is fully visible in /proc , and
b) ->proc_fops are proc_file_operations which do not have ->open callback. So, it's
possible to ->read without ->open (see one class of oopses below).
The fix is new API called proc_create() which makes sure ->proc_fops are
set up before gluing PDE to main tree. Typical new code looks like:
pde = proc_create("foo", 0, NULL, &foo_proc_fops);
if (!pde)
return -ENOMEM;
Fix most networking users for a start.
In the long run, create_proc_entry() for regular files will go.
In addition to this, proc_create_data is introduced to fix reading from
proc without PDE->data. The race is basically the same as above.
create_proc_entries is replaced in the entire kernel code as new method
is also simply better.
This patch:
The problem is the same as for de->proc_fops. Right now PDE becomes visible
without data set. So, the entry could be looked up without data. This, in
most cases, will simply OOPS.
proc_create_data call is created to address this issue. proc_create now
becomes a wrapper around it.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Chris Mason <chris.mason@oracle.com>
Acked-by: David Howells <dhowells@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jaroslav Kysela <perex@suse.cz>
Cc: Jeff Garzik <jgarzik@pobox.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Karsten Keil <kkeil@suse.de>
Cc: Kyle McMartin <kyle@parisc-linux.org>
Cc: Len Brown <lenb@kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Mikael Starvik <starvik@axis.com>
Cc: Nadia Derbey <Nadia.Derbey@bull.net>
Cc: Neil Brown <neilb@suse.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Pierre Peiffer <peifferp@gmail.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 08:06:20 -07:00
..
2008-04-25 09:23:25 -04:00
2008-04-29 08:05:59 -07:00
2008-04-29 08:06:02 -07:00
2008-04-16 07:43:48 -07:00
2008-04-29 08:06:01 -07:00
2008-04-29 08:05:59 -07:00
2008-04-29 08:06:18 -07:00
2008-04-29 08:06:04 -07:00
2008-04-18 22:16:44 -04:00
2008-03-04 14:47:06 -08:00
2008-04-22 13:44:23 -07:00
2008-04-29 08:06:07 -07:00
2008-04-02 15:28:19 -07:00
2008-04-28 08:58:43 -07:00
2008-04-28 08:58:45 -07:00
2008-04-29 08:06:18 -07:00
2008-04-28 08:58:47 -07:00
2008-04-29 08:06:00 -07:00
2008-04-25 09:23:25 -04:00
2008-04-28 08:58:18 -07:00
2008-04-29 08:06:01 -07:00
2008-04-29 08:06:02 -07:00
2008-03-19 06:42:18 -04:00
2008-04-28 08:58:25 -07:00
2008-03-19 18:53:36 -07:00
2008-04-28 08:58:45 -07:00
2008-03-30 14:18:41 -07:00
2008-04-23 16:43:15 +01:00
2008-04-29 08:06:18 -07:00
2008-04-25 13:00:11 -04:00
2008-04-28 08:58:47 -07:00
2008-04-28 08:58:29 -07:00
2008-04-29 08:06:18 -07:00
2008-04-25 13:00:11 -04:00
2008-04-19 00:29:24 -04:00
2008-04-28 08:58:47 -07:00
2008-04-29 08:06:20 -07:00
2008-04-29 08:06:00 -07:00
2008-04-28 08:58:46 -07:00
2008-03-19 18:53:36 -07:00
2008-03-30 14:18:41 -07:00
2008-04-22 15:16:31 -05:00
2008-04-28 08:58:46 -07:00
2008-04-28 08:58:45 -07:00
2008-04-28 08:58:47 -07:00
2008-04-21 15:41:27 -07:00
2008-04-29 08:06:00 -07:00
2008-03-19 06:54:05 -04:00
2008-04-29 08:06:04 -07:00
2008-04-29 08:06:05 -07:00
2008-04-29 08:06:16 -07:00
2008-04-29 08:06:04 -07:00
2008-04-29 08:06:17 -07:00
2008-04-29 08:06:04 -07:00
2008-04-29 08:06:04 -07:00
2008-04-25 09:23:53 -04:00
2008-04-21 09:50:08 +02:00
2008-04-29 08:06:01 -07:00
2008-04-29 08:06:01 -07:00
2008-04-23 00:04:38 -04:00
2008-04-28 08:58:33 -07:00
2008-04-29 08:06:05 -07:00
2008-04-29 08:05:59 -07:00
2008-04-29 08:06:17 -07:00
2008-04-25 09:24:05 -04:00
2008-04-19 00:29:28 -04:00
2008-04-29 08:06:00 -07:00
2008-04-29 08:06:06 -07:00
2008-04-21 23:11:01 -04:00
2008-04-29 08:06:00 -07:00
2008-04-24 11:46:16 -07:00
2008-04-29 08:06:01 -07:00
2008-04-25 15:49:46 -07:00
2008-04-15 19:35:41 -07:00
2008-03-03 10:47:13 -08:00
2008-04-29 08:06:09 -07:00
2008-04-29 08:06:06 -07:00
2008-04-28 08:58:23 -07:00
2008-04-22 19:54:57 -04:00
2008-04-23 00:05:09 -04:00
2008-04-23 00:05:09 -04:00
2008-04-28 08:58:32 -07:00
2008-04-28 08:58:32 -07:00
2008-04-28 08:58:33 -07:00
2008-04-22 15:17:11 -07:00
2008-04-21 22:15:06 +00:00
2008-04-23 00:04:38 -04:00
2008-04-11 08:06:44 -07:00
2008-04-10 08:24:25 +02:00
2008-04-29 08:06:00 -07:00
2008-04-29 08:06:06 -07:00
2008-04-29 08:06:01 -07:00
2008-04-19 00:29:24 -04:00
2008-04-29 08:06:06 -07:00