Bartlomiej Zolnierkiewicz 93de00fd1c
ide: remove broken/dangerous HDIO_[UNREGISTER,SCAN]_HWIF ioctls (take 3) ...
hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS
and given the number of bugs we can assume that there are no real users:
* DMA has no chance of working because DMA resources are released by
ide_unregister() and they are never allocated again.
* Since ide_init_hwif_ports() is used for ->io_ports[] setup the ioctls
don't work for almost all hosts with "non-standard" (== non ISA-like)
layout of IDE taskfile registers (there is a lot of such host drivers).
* ide_port_init_devices() is not called when probing IDE devices so:
- drive->autotune is never set and IDE host/devices are not programmed
for the correct PIO/DMA transfer modes (=> possible data corruption)
- host specific I/O 32-bit and IRQ unmasking settings are not applied
(=> possible data corruption)
- host specific ->port_init_devs method is not called (=> no luck with
ht6560b, qd65xx and opti621 host drivers)
* ->rw_disk method is not preserved (=> no HPT3xxN chipsets support).
* ->serialized flag is not preserved (=> possible data corruption when
using icside, aec62xx (ATP850UF chipset), cmd640, cs5530, hpt366
(HPT3xxN chipsets), rz1000, sc1200, dtc2278 and ht6560b host drivers).
* ->ack_intr method is not preserved (=> needed by ide-cris, buddha,
gayle and macide host drivers).
* ->sata_scr[] and sata_misc[] is cleared by ide_unregister() and it
isn't initialized again (SiI3112 support needs them).
* To issue an ioctl() there need to be at least one IDE device present
in the system.
* ->cable_detect method is not preserved + it is not called when probing
IDE devices so cable detection is broken (however since DMA support is
also broken it doesn't really matter ;-).
* Some objects which may have already been freed in ide_unregister()
are restored by ide_hwif_restore() (i.e. ->hwgroup).
* ide_register_hw() may unregister unrelated IDE ports if free ide_hwifs[]
slot cannot be found.
* When IDE host drivers are modular unregistered port may be re-used by
different host driver that owned it first causing subtle bugs.
Since we now have a proper warm-plug support remove these ioctls,
then remove no longer needed:
- ide_register_hw() and ide_hwif_restore() functions
- 'init_default' and 'restore' arguments of ide_unregister()
- zeroeing of hwif->{dma,extra}_* fields in ide_unregister()
As an added bonus IDE core code size shrinks by ~3kB (x86-32).
v2:
* fix ide_unregister() arguments in cleanup_module() (Andrew Morton).
v3:
* fix ide_unregister() arguments in palm_bk3710.c.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
2008-04-18 00:46:24 +02:00
2008-02-08 09:22:32 -08:00
2008-01-28 14:54:13 -08:00
2007-07-30 16:26:27 -03:00
2008-02-06 10:41:15 -08:00
2008-02-01 16:42:02 -05:00
2008-02-07 08:42:23 -08:00
2008-02-08 13:30:02 -08:00
2007-12-12 20:01:01 +01:00
2008-02-07 10:30:48 +00:00
2008-03-10 16:41:06 -07:00
2008-01-31 19:27:40 -08:00
2007-10-15 12:26:29 -07:00
2008-01-31 19:27:36 -08:00
2008-01-31 19:27:39 -08:00
2008-02-14 21:17:08 -08:00
2008-03-04 16:35:18 -08:00
2008-02-05 09:44:13 -08:00
2008-04-15 15:04:35 -04:00
2008-02-10 18:11:16 -05:00
2007-12-26 19:36:35 -08:00
2008-02-05 03:20:13 -08:00
2008-03-24 22:26:14 -07:00
2008-02-08 09:22:30 -08:00
2008-02-06 10:41:02 -08:00
2008-02-06 10:41:10 -08:00
2008-01-30 13:30:18 +01:00
2008-02-14 02:43:39 -05:00
2007-09-11 04:22:16 -07:00
2008-02-05 14:33:32 +10:00
2008-02-05 14:33:32 +10:00
2008-02-19 10:04:00 +01:00
2007-12-17 19:28:16 -08:00
2007-10-10 16:51:59 -07:00
2008-02-06 10:12:18 -07:00
2008-02-06 06:54:17 -05:00
2008-02-24 00:27:33 -05:00
2008-01-28 15:00:14 -08:00
2008-01-28 15:00:12 -08:00
2008-02-08 09:22:38 -08:00
2008-02-04 13:16:39 +00:00
2007-10-17 08:42:47 -07:00
2008-01-23 11:29:17 -06:00
2008-02-14 21:17:08 -08:00
2007-10-17 08:43:00 -07:00
2007-10-17 08:42:45 -07:00
2007-10-11 22:24:13 +01:00
2007-10-17 08:43:07 -07:00
2008-02-19 10:04:00 +01:00
2007-10-18 14:37:29 -07:00
2007-10-19 11:53:42 -07:00
2008-03-28 14:45:22 -07:00
2008-03-04 11:18:17 +01:00
2008-01-29 21:55:15 +01:00
2008-02-07 08:42:25 -08:00
2007-07-31 10:43:05 -05:00
2008-02-13 16:21:18 -08:00
2008-01-28 14:54:10 -08:00
2008-02-05 09:44:20 -08:00
2008-02-01 23:09:24 +01:00
2008-03-04 16:35:12 -08:00
2008-04-04 14:46:26 -07:00
2007-10-19 11:53:36 -07:00
2008-02-03 17:45:46 +02:00
2007-10-14 22:57:45 +02:00
2008-01-30 13:30:02 +01:00
2008-03-30 14:20:23 -07:00
2008-01-28 23:21:18 +01:00
2008-02-09 23:24:09 +01:00
2007-10-18 14:37:32 -07:00
2007-10-17 08:42:47 -07:00
2008-03-04 16:35:12 -08:00
2007-12-06 17:40:19 -05:00
2008-02-14 20:58:05 -08:00
2008-02-26 18:42:44 -08:00
2007-10-16 09:43:20 -07:00
2007-10-18 14:37:19 -07:00
2007-10-17 08:42:52 -07:00
2008-01-30 13:32:42 +01:00
2008-01-25 21:08:02 +01:00
2008-02-06 22:57:58 -05:00
2008-03-26 00:45:26 -04:00
2008-01-30 13:31:10 +01:00
2008-02-11 20:48:29 -08:00
2007-10-17 08:42:53 -07:00
2008-01-11 08:17:01 +11:00
2008-02-03 17:45:46 +02:00
2008-02-03 15:42:53 +02:00
2008-02-08 15:33:33 -08:00
2008-02-14 21:17:09 -08:00
2008-02-03 04:28:53 -08:00
2008-02-14 21:17:08 -08:00
2008-01-25 21:08:02 +01:00
2008-03-04 14:47:06 -08:00
2008-03-04 16:35:12 -08:00
2007-10-19 11:53:36 -07:00
2008-02-08 02:10:01 +00:00
2008-02-05 09:44:10 -08:00
2008-01-25 14:46:04 -08:00
2008-01-25 14:46:04 -08:00
2008-02-11 11:06:35 -05:00
2008-02-08 02:09:56 +00:00
2008-02-05 09:44:11 -08:00
2008-03-30 14:20:23 -07:00
2008-02-08 09:22:24 -08:00
2008-02-08 09:22:37 -08:00
2008-02-07 08:42:06 -08:00
2007-10-23 15:49:47 +10:00
2007-10-10 16:53:56 -07:00
2007-10-22 08:13:19 -07:00
2007-12-18 08:29:28 +01:00
2008-02-08 09:22:30 -08:00
2008-02-07 09:02:26 -08:00
2008-02-29 08:06:37 -08:00
2008-02-07 08:42:30 -08:00
2008-01-28 23:21:18 +01:00
2008-02-07 18:04:10 -06:00
2008-02-07 08:42:25 -08:00
2008-02-13 16:21:19 -08:00
2008-03-07 11:11:13 -08:00
2007-10-29 07:41:32 -07:00
2008-03-14 09:49:57 -07:00
2007-10-17 08:43:02 -07:00
2007-11-29 09:24:53 -08:00
2007-10-17 08:42:48 -07:00
2008-02-07 08:42:27 -08:00
2008-02-25 16:54:37 -05:00
2008-01-29 00:19:52 -05:00
2008-01-29 00:19:52 -05:00
2008-02-10 01:11:44 -05:00
2007-10-17 18:49:58 -04:00
2007-11-08 08:42:46 -05:00
2007-10-16 09:43:22 -07:00
2007-10-17 08:43:01 -07:00
2008-02-13 16:21:18 -08:00
2007-10-17 21:21:26 -07:00
2007-10-17 00:00:08 +02:00
2008-03-10 16:33:33 -07:00
2007-10-18 14:37:19 -07:00
2007-10-10 16:54:03 -07:00
2008-02-14 21:13:33 -08:00
2008-02-19 10:04:00 +01:00
2008-02-06 10:41:05 -08:00
2007-11-29 09:24:54 -08:00
2008-02-23 17:12:15 -08:00
2008-03-12 12:34:37 -07:00
2008-02-13 16:21:18 -08:00
2007-10-10 08:55:27 +01:00
2007-09-26 00:01:17 -04:00
2008-03-04 16:35:10 -08:00
2008-03-28 14:45:21 -07:00
2008-02-06 10:41:00 -08:00
2008-02-07 08:42:34 -08:00
2008-02-05 13:31:39 -05:00
2007-10-14 12:41:51 -07:00
2008-04-18 00:46:24 +02:00
2008-02-19 01:41:26 +01:00
2008-02-11 13:01:51 +01:00
2007-10-15 08:12:00 -07:00
2008-02-05 09:44:19 -08:00
2008-04-04 18:36:49 +02:00
2008-02-10 10:48:03 +01:00
2008-02-13 16:21:18 -08:00
2008-02-05 09:44:23 -08:00
2007-10-09 22:56:30 -04:00
2007-10-13 23:56:32 +02:00
2008-02-07 20:39:44 -05:00
2008-02-24 20:03:42 +01:00
2007-10-16 11:21:00 +02:00
2007-10-22 00:56:52 -04:00
2008-04-18 00:46:24 +02:00
2008-02-01 16:13:16 -05:00
2008-01-28 14:53:58 -08:00
2007-10-10 16:51:59 -07:00
2008-01-28 14:54:09 -08:00
2007-12-07 15:00:32 -05:00
2007-10-15 12:26:29 -07:00
2007-10-10 16:51:16 -07:00
2008-02-23 20:09:11 -08:00
2007-10-17 08:42:52 -07:00
2008-01-28 15:07:58 -08:00
2007-10-10 16:49:13 -07:00
2007-08-26 18:35:42 -07:00
2007-10-10 16:52:04 -07:00
2008-01-28 14:56:28 -08:00
2008-04-12 18:48:58 -07:00
2008-01-28 14:55:09 -08:00
2008-02-05 16:20:22 -08:00
2008-01-28 14:55:09 -08:00
2008-03-17 22:48:46 -07:00
2007-12-05 05:37:32 -08:00
2008-01-31 19:28:31 -08:00
2008-01-30 13:34:11 +01:00
2008-02-05 09:44:20 -08:00
2008-02-19 21:00:18 +01:00
2007-10-21 02:37:38 -04:00
2008-04-01 00:22:53 -04:00
2008-02-13 16:21:18 -08:00
2008-04-15 09:25:33 +02:00
2008-03-04 16:35:17 -08:00
2008-01-30 13:30:32 +01:00
2008-01-28 10:50:29 +01:00
2008-02-08 09:22:26 -08:00
2008-02-08 09:22:23 -08:00
2007-10-30 08:06:55 -07:00
2007-10-18 14:37:32 -07:00
2008-04-13 23:33:52 -07:00
2008-02-13 16:21:18 -08:00
2007-09-16 21:13:58 -07:00
2008-02-06 10:41:07 -08:00
2008-02-07 08:42:33 -08:00
2008-02-07 08:42:34 -08:00
2007-10-09 22:07:28 -03:00
2007-10-09 22:07:23 -03:00
2008-01-28 23:58:27 -05:00
2008-03-19 18:53:36 -07:00
2008-02-08 09:22:29 -08:00
2007-11-05 15:12:32 -08:00
2007-10-17 08:42:52 -07:00
2007-08-22 19:52:45 -07:00
2008-04-12 18:48:58 -07:00
2007-11-29 09:24:52 -08:00
2007-07-31 15:39:40 -07:00
2007-10-18 14:37:28 -07:00
2008-02-08 09:22:41 -08:00
2008-02-07 08:42:25 -08:00
2007-10-17 08:42:57 -07:00
2008-01-08 16:10:35 -08:00
2007-10-19 11:53:33 -07:00
2008-01-24 21:27:06 -08:00
2008-03-04 16:35:11 -08:00
2008-01-24 20:40:05 -08:00
2008-02-14 22:08:30 +01:00
2008-03-04 15:19:40 +02:00
2008-01-30 18:01:22 +02:00
2008-01-30 18:01:18 +02:00
2008-03-03 11:22:25 +02:00
2008-01-25 21:08:34 +01:00
2008-02-07 09:49:38 +00:00
2008-03-28 11:05:54 +11:00
2007-10-25 15:02:50 +10:00
2008-04-04 02:43:36 -04:00
2008-04-11 08:29:13 -07:00
2007-10-19 11:53:35 -07:00
2008-02-03 17:45:46 +02:00
2007-10-19 11:53:38 -07:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:01 -08:00
2008-02-06 10:41:01 -08:00
2007-10-19 11:53:36 -07:00
2008-02-26 14:03:47 +09:00
2008-03-04 16:35:14 -08:00
2008-04-15 19:35:41 -07:00
2007-11-14 18:45:41 -08:00
2007-10-10 16:54:03 -07:00
2008-03-04 16:35:15 -08:00
2007-10-16 09:43:02 -07:00
2007-10-22 08:13:17 -07:00
2007-10-19 11:53:36 -07:00
2008-03-19 18:53:37 -07:00
2008-02-05 09:44:23 -08:00
2008-03-04 16:35:12 -08:00
2008-03-12 12:34:37 -07:00
2008-02-05 09:44:18 -08:00
2008-02-05 09:44:08 -08:00
2008-02-14 20:58:04 -08:00
2008-02-13 16:21:19 -08:00
2008-03-27 20:47:58 -04:00
2007-11-07 04:08:55 -08:00
2007-10-19 11:53:44 -07:00
2008-02-13 16:21:18 -08:00
2008-02-08 09:22:31 -08:00
2007-10-30 14:32:16 -04:00
2008-01-26 15:04:01 +00:00
2008-01-26 15:03:59 +00:00
2008-02-14 21:13:33 -08:00
2008-02-08 09:22:41 -08:00
2008-01-28 14:56:29 -08:00
2008-03-28 16:33:00 -07:00
2007-12-14 13:54:39 -08:00
2008-01-28 14:53:55 -08:00
2008-01-28 14:53:55 -08:00
2008-02-27 12:21:18 -08:00
2008-01-31 19:28:23 -08:00
2008-03-04 12:28:49 -08:00
2008-01-30 02:06:07 -05:00
2008-03-07 14:35:37 -05:00
2007-12-06 17:40:25 -05:00
2008-01-30 02:05:24 -05:00
2008-01-30 02:06:08 -05:00
2008-02-01 16:42:05 -05:00
2008-01-28 14:59:52 -08:00
2007-10-17 08:42:58 -07:00
2007-10-16 09:42:58 -07:00
2008-02-01 18:30:53 -05:00
2007-10-19 11:53:37 -07:00
2008-02-05 09:44:24 -08:00
2008-01-17 14:53:22 +11:00
2007-10-17 21:17:42 -07:00
2008-02-06 16:29:59 +11:00
2007-10-17 08:42:46 -07:00
2008-02-21 16:40:15 -08:00
2007-10-16 09:43:02 -07:00
2007-10-16 09:43:02 -07:00
2008-02-13 16:21:18 -08:00
2007-10-23 19:53:16 -04:00
2008-02-14 21:13:33 -08:00
2008-01-24 20:40:14 -08:00
2008-03-10 18:01:19 -07:00
2008-02-02 11:32:01 -08:00
2008-02-01 15:04:29 -08:00
2008-03-24 22:38:44 -07:00
2008-01-28 15:00:35 -08:00
2008-02-02 02:44:34 +03:00
2007-10-17 08:42:44 -07:00
2008-02-06 10:41:04 -08:00
2008-02-07 23:11:56 -08:00
2007-10-19 11:53:41 -07:00
2008-01-23 19:33:58 -06:00
2008-02-03 04:28:41 -08:00
2008-02-08 09:22:23 -08:00
2008-02-13 16:21:18 -08:00
2008-03-17 22:46:46 -07:00
2008-01-31 19:28:35 -08:00
2008-01-24 20:40:06 -08:00
2008-01-24 20:40:43 -08:00
2008-01-11 12:26:47 -05:00
2008-02-05 09:44:22 -08:00
2008-02-23 10:40:04 -08:00
2008-03-13 10:09:27 +11:00
2008-04-11 08:06:44 -07:00
2007-07-26 11:35:21 -07:00
2007-10-17 18:49:58 -04:00
2007-09-11 17:21:20 -07:00
2008-02-05 21:15:50 -05:00
2008-02-05 09:44:20 -08:00
2008-02-08 09:22:31 -08:00
2007-10-19 20:35:04 +02:00
2007-10-19 11:53:41 -07:00
2008-03-07 11:08:40 -08:00
2007-10-17 08:42:55 -07:00
2007-10-17 08:42:45 -07:00
2008-02-08 09:22:26 -08:00
2008-02-07 08:42:28 -08:00
2007-12-23 12:54:36 -08:00
2007-10-17 08:42:56 -07:00
2008-02-03 16:12:47 +02:00
2008-02-29 18:46:50 +01:00
2008-02-06 10:41:06 -08:00
2008-01-25 21:08:24 +01:00
2008-03-19 18:53:36 -07:00
2008-02-05 09:44:22 -08:00
2008-01-30 13:31:47 +01:00
2008-02-03 15:42:53 +02:00
2008-02-08 09:22:41 -08:00
2008-02-07 08:42:18 -08:00
2008-01-31 19:26:46 -08:00
2008-02-07 08:42:19 -08:00
2007-11-29 09:24:54 -08:00
2008-02-05 03:17:22 -08:00
2008-02-13 16:21:18 -08:00
2008-01-28 10:54:49 +01:00
2008-03-26 08:28:55 +01:00
2007-11-29 09:24:54 -08:00
2008-02-05 10:59:07 -05:00
2007-10-14 12:41:51 -07:00
2008-03-20 09:46:36 -07:00
2007-10-16 09:43:17 -07:00
2008-01-30 08:17:26 +11:00
2007-10-19 11:53:44 -07:00
2008-02-14 21:17:08 -08:00
2008-02-07 08:42:34 -08:00
2008-02-05 09:44:09 -08:00
2008-02-13 16:21:18 -08:00
2007-08-22 19:52:44 -07:00
2008-02-26 14:52:45 +09:00
2008-02-07 08:42:30 -08:00
2008-02-08 09:22:41 -08:00
2008-02-08 09:22:27 -08:00
2008-02-03 15:12:15 +02:00
2008-02-18 20:52:13 -08:00
2008-03-06 16:21:49 -08:00
2008-01-02 13:04:48 -08:00
2008-03-03 12:22:32 -08:00
2008-03-04 16:35:13 -08:00
2008-03-04 16:35:13 -08:00
2008-01-25 21:08:33 +01:00
2008-01-30 13:33:17 +01:00
2008-01-31 19:28:30 -08:00
2008-01-28 14:56:57 -08:00
2008-01-24 00:47:27 -05:00
2008-02-03 17:45:46 +02:00
2008-01-30 13:31:20 +01:00
2008-01-30 13:31:20 +01:00
2008-04-11 13:17:46 -06:00
2008-01-28 14:53:30 -08:00
2008-01-25 21:08:34 +01:00
2008-02-07 08:42:34 -08:00
2007-10-30 21:44:00 -07:00
2008-02-01 18:30:53 -05:00
2008-02-05 09:44:17 -08:00
2008-02-13 16:21:18 -08:00
2008-02-09 11:08:33 -08:00
2008-02-05 09:44:07 -08:00
2008-02-05 09:44:20 -08:00
2008-01-24 20:40:40 -08:00
2008-01-23 11:29:18 -06:00
2007-10-18 14:37:28 -07:00
2008-01-28 14:54:07 -08:00
2008-04-15 19:35:41 -07:00
2008-02-01 17:45:14 +01:00
2008-02-01 17:45:14 +01:00
2008-03-10 18:01:18 -07:00
2008-03-09 08:42:57 +01:00
2008-02-08 09:22:37 -08:00
2008-03-09 08:42:57 +01:00
2008-03-21 16:43:48 +01:00
2008-02-07 08:42:16 -08:00
2008-02-08 09:22:39 -08:00
2008-02-08 09:22:34 -08:00
2008-02-08 09:22:36 -08:00
2007-10-19 11:53:42 -07:00
2008-01-24 20:40:26 -08:00
2008-03-24 22:26:14 -07:00
2008-03-04 14:57:43 -08:00
2008-02-01 14:34:58 -08:00
2007-09-19 11:24:18 -07:00
2008-02-08 09:22:23 -08:00
2007-12-26 19:36:35 -08:00
2007-10-12 14:51:04 -07:00
2008-02-18 12:18:05 -03:00
2008-02-18 12:18:05 -03:00
2007-10-23 13:47:31 -05:00
2008-02-04 23:50:13 +11:00
2008-02-04 23:50:01 +11:00
2008-02-04 23:50:03 +11:00
2007-10-23 15:49:55 +10:00
2008-02-04 23:50:02 +11:00
2008-02-04 23:50:12 +11:00
2008-02-04 23:50:00 +11:00
2008-04-07 13:14:22 -07:00
2008-02-05 09:44:14 -08:00
2008-02-29 08:36:13 -08:00
2008-02-06 10:41:03 -08:00
2007-10-19 11:53:34 -07:00
2008-02-06 10:41:15 -08:00
2008-02-13 16:21:18 -08:00
2008-02-03 15:42:53 +02:00
2008-02-13 16:21:18 -08:00
2008-02-05 09:44:19 -08:00
2008-02-05 09:44:20 -08:00
2008-01-31 19:27:03 -08:00
2007-10-12 14:05:17 +10:00
2007-10-10 16:53:57 -07:00
93de00fd1c