Alexey Dobriyan 99b7623380
proc 2/2: remove struct proc_dir_entry::owner ...
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454 . Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.
We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.
But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.
->read_proc/->write_proc were just fixed to not require ->owner for
protection.
rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.
Removing ->owner will also make PDE smaller.
So, let's nuke it.
Kudos to Jeff Layton for reminding about this, let's say, oversight.
http://bugzilla.kernel.org/show_bug.cgi?id=12454
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com >
2009-03-31 01:14:44 +04:00
2009-01-06 18:10:26 -08:00
2009-01-30 19:50:25 +05:30
2009-01-08 15:14:17 -08:00
2009-03-26 18:14:15 +01:00
2009-01-06 17:14:01 -08:00
2009-03-10 20:33:19 -04:00
2009-03-11 13:49:46 +00:00
2009-03-18 19:45:11 -07:00
2008-12-31 18:18:13 +01:00
2009-01-09 12:37:15 -08:00
2009-03-26 22:45:23 -07:00
2009-03-26 18:14:14 +01:00
2009-03-26 16:11:41 -07:00
2009-01-30 23:30:42 +05:30
2009-01-30 23:32:45 +05:30
2009-01-08 20:10:38 +00:00
2009-02-24 03:50:29 -08:00
2009-03-05 14:39:32 -05:00
2009-01-06 11:53:47 -05:00
2009-01-30 23:34:34 +05:30
2009-01-30 23:36:36 +05:30
2009-03-26 15:23:24 -07:00
2009-03-24 16:38:23 -07:00
2009-01-02 10:19:37 -08:00
2009-02-16 00:43:24 +01:00
2009-03-26 18:14:14 +01:00
2009-01-30 23:38:03 +05:30
2008-12-29 08:29:50 +01:00
2009-01-21 14:02:19 -08:00
2009-01-06 11:38:14 -07:00
2009-02-08 09:56:11 -08:00
2009-03-26 11:20:23 -07:00
2009-01-30 23:38:37 +05:30
2009-01-29 16:00:33 -05:00
2009-01-15 16:39:41 -08:00
2009-01-30 23:39:08 +05:30
2009-01-09 11:52:14 -08:00
2009-03-26 18:14:15 +01:00
2009-03-26 18:14:15 +01:00
2009-02-12 09:40:14 +11:00
2009-01-06 15:59:23 -08:00
2009-01-30 23:39:42 +05:30
2009-01-08 08:31:12 -08:00
2009-01-08 15:37:43 +00:00
2009-01-30 23:40:06 +05:30
2009-01-06 15:59:29 -08:00
2009-03-24 12:35:17 +01:00
2008-12-30 09:05:13 +10:30
2009-01-01 10:12:19 +10:30
2009-02-26 10:45:48 +01:00
2009-02-18 10:32:00 +01:00
2009-01-04 13:33:20 -08:00
2009-02-24 11:57:21 +09:00
2009-03-28 13:30:43 -07:00
2009-03-27 14:44:03 -04:00
2009-03-17 14:55:55 -04:00
2009-01-15 16:39:41 -08:00
2009-01-30 23:44:08 +05:30
2009-02-11 14:25:36 -08:00
2009-01-30 23:44:41 +05:30
2009-03-27 14:51:13 +01:00
2009-01-30 22:35:29 +01:00
2009-02-15 22:43:31 -08:00
2009-03-26 18:14:15 +01:00
2009-03-26 18:14:14 +01:00
2009-02-03 19:32:24 +05:30
2009-01-23 22:28:48 -08:00
2009-03-27 14:43:57 -04:00
2009-01-02 12:19:34 -08:00
2009-03-26 18:14:23 +01:00
2009-03-12 21:33:03 +00:00
2009-01-02 09:23:03 -08:00
2009-02-02 23:22:04 -08:00
2009-03-24 16:38:26 -07:00
2009-03-09 15:07:33 -04:00
2009-01-01 10:12:30 +10:30
2009-01-08 08:31:11 -08:00
2008-12-25 11:01:43 +11:00
2009-03-04 15:05:33 +08:00
2009-03-26 18:14:14 +01:00
2009-03-21 13:31:23 -07:00
2009-03-27 14:43:59 -04:00
2009-03-01 00:19:35 -08:00
2009-01-21 14:34:05 -08:00
2009-01-26 19:21:26 -08:00
2009-01-06 03:05:09 +00:00
2009-03-24 16:38:26 -07:00
2009-01-12 20:56:41 +01:00
2009-03-26 18:14:15 +01:00
2009-01-30 23:45:32 +05:30
2009-03-26 18:14:15 +01:00
2009-01-04 11:00:05 +01:00
2009-03-08 10:23:05 -07:00
2009-03-17 15:45:07 -07:00
2009-01-28 07:50:14 -08:00
2009-01-30 23:46:03 +05:30
2009-01-05 08:40:21 -08:00
2009-01-05 08:40:25 -08:00
2009-01-05 08:40:25 -08:00
2009-01-06 11:38:16 -07:00
2009-03-24 16:38:27 -07:00
2009-01-30 23:46:40 +05:30
2009-01-30 23:47:07 +05:30
2008-12-29 08:29:50 +01:00
2009-01-30 23:47:59 +05:30
2009-01-30 23:48:33 +05:30
2009-02-10 00:41:26 +01:00
2009-02-15 22:43:33 -08:00
2009-02-08 20:22:18 -08:00
2009-02-20 00:58:13 -08:00
2009-03-16 08:32:27 -06:00
2009-01-08 08:31:00 -08:00
2009-01-08 08:31:00 -08:00
2009-01-08 17:14:59 -08:00
2009-01-08 17:14:59 -08:00
2008-12-29 11:27:46 +02:00
2009-02-05 12:56:46 -08:00
2008-12-31 18:07:42 -05:00
2009-03-24 20:56:50 +01:00
2009-02-18 15:37:56 -08:00
2009-03-28 17:30:00 -07:00
2009-03-30 11:31:47 -07:00
2009-02-18 13:43:04 -05:00
2009-03-20 01:33:32 -07:00
2009-01-02 10:19:38 -08:00
2009-01-30 23:49:39 +05:30
2009-03-24 12:35:17 +01:00
2009-01-06 15:59:01 -08:00
2009-01-30 23:50:12 +05:30
2008-12-30 16:10:19 -08:00
2009-01-21 14:03:37 -08:00
2009-02-17 17:37:40 -08:00
2009-03-05 16:10:59 +01:00
2009-01-30 23:50:37 +05:30
2009-01-30 23:51:17 +05:30
2009-01-04 01:00:51 +01:00
2009-02-10 14:56:59 -08:00
2009-03-28 21:34:44 +01:00
2009-02-24 19:19:49 +01:00
2009-03-30 12:43:28 -03:00
2009-03-28 21:34:45 +01:00
2009-02-24 19:19:49 +01:00
2009-01-21 14:02:26 -08:00
2009-01-30 23:51:41 +05:30
2009-03-27 12:46:47 +01:00
2009-03-27 20:13:02 -04:00
2009-01-30 23:52:16 +05:30
2009-01-30 23:52:41 +05:30
2009-03-26 18:14:15 +01:00
2009-03-28 13:30:43 -07:00
2009-01-30 23:53:12 +05:30
2009-03-27 00:46:44 -07:00
2009-01-30 23:53:40 +05:30
2009-01-30 23:54:53 +05:30
2009-01-30 23:55:45 +05:30
2009-03-26 18:14:14 +01:00
2009-02-14 22:58:35 -08:00
2009-01-30 23:56:13 +05:30
2009-01-30 23:56:48 +05:30
2009-02-05 21:25:32 -08:00
2009-02-14 22:58:35 -08:00
2009-02-18 23:31:11 -08:00
2009-01-21 14:03:35 -08:00
2009-01-30 23:57:16 +05:30
2009-02-11 15:27:15 +11:00
2009-02-02 21:40:58 +05:30
2009-01-30 23:57:43 +05:30
2009-02-01 01:04:33 -08:00
2009-02-15 21:15:16 +01:00
2009-03-24 00:35:43 +01:00
2009-03-17 15:39:20 -07:00
2009-03-27 17:28:43 +01:00
2009-03-02 09:43:32 +01:00
2009-01-03 14:10:09 +01:00
2009-01-15 16:39:38 -08:00
2009-01-05 22:46:26 -05:00
2009-01-30 23:58:12 +05:30
2009-03-26 18:14:15 +01:00
2009-03-31 01:14:44 +04:00
2009-01-30 23:59:12 +05:30
2009-01-30 23:58:41 +05:30
2009-01-30 23:59:44 +05:30
2009-01-31 00:00:06 +05:30
2009-03-29 08:19:09 -07:00
2009-03-27 17:28:43 +01:00
2009-03-13 14:32:29 +01:00
2009-01-02 10:19:40 -08:00
2009-03-30 12:43:22 -03:00
2009-03-26 18:14:15 +01:00
2009-02-10 11:15:34 -05:00
2009-01-15 16:39:37 -08:00
2009-03-26 18:14:17 +01:00
2009-01-05 08:40:30 -08:00
2009-01-15 16:39:41 -08:00
2009-03-30 12:43:15 -03:00
2009-01-22 10:18:58 +01:00
2009-03-24 16:38:27 -07:00
2009-01-20 20:52:10 -08:00
2009-03-24 16:38:26 -07:00
2009-02-21 00:09:42 +01:00
2009-03-24 11:03:11 +02:00
2009-03-24 11:02:55 +02:00
2009-03-24 11:03:15 +02:00
2009-02-11 10:18:04 +01:00
2009-01-08 12:38:58 +00:00
2009-01-08 17:55:03 +00:00
2008-12-30 09:26:11 +10:30
2009-03-24 22:52:39 -04:00
2008-12-30 16:20:19 -08:00
2009-01-15 16:39:41 -08:00
2009-01-21 10:39:51 +01:00
2009-03-12 12:58:05 -05:00
2008-12-29 04:59:31 -08:00
2009-02-27 16:07:32 +09:00
2009-03-26 18:14:15 +01:00
2009-01-08 08:31:10 -08:00
2009-01-06 15:59:00 -08:00
2009-01-06 15:59:00 -08:00
2009-01-09 16:54:41 -08:00
2009-01-06 15:59:00 -08:00
2009-01-31 00:00:35 +05:30
2009-03-13 15:57:40 -05:00
2009-01-09 22:44:25 +01:00
2009-01-11 17:55:16 +01:00
2009-01-08 08:31:07 -08:00
2009-03-12 14:35:44 +10:30
2009-03-14 09:47:44 +01:00
2009-02-21 00:09:42 +01:00
2009-02-18 15:37:55 -08:00
2009-03-24 16:38:24 -07:00
2009-02-07 08:33:01 -08:00
2009-01-05 08:40:13 +10:30
2009-03-26 10:56:35 -07:00
2009-03-26 18:14:14 +01:00
2009-01-22 13:57:41 -08:00
2009-01-31 00:01:11 +05:30
2008-12-31 18:07:38 -05:00
2009-03-27 14:44:00 -04:00
2009-02-14 22:58:35 -08:00
2009-03-04 00:03:08 -08:00
2009-03-13 12:09:29 -07:00
2009-02-15 22:43:33 -08:00
2009-03-15 19:59:13 -07:00
2009-03-28 13:30:43 -07:00
2009-02-14 22:58:35 -08:00
2009-03-24 16:37:55 -07:00
2009-03-16 10:50:02 -07:00
2009-01-07 17:38:31 -05:00
2009-03-27 14:43:59 -04:00
2009-01-31 00:02:27 +05:30
2009-03-27 14:43:59 -04:00
2009-03-10 20:33:18 -04:00
2009-03-27 20:13:04 -04:00
2009-01-06 15:59:00 -08:00
2009-02-03 19:33:51 +05:30
2009-01-08 16:25:18 +11:00
2009-01-09 15:49:06 -07:00
2009-01-07 22:48:15 +01:00
2009-01-07 09:59:50 -08:00
2009-01-08 08:31:05 -08:00
2009-01-06 15:59:07 -08:00
2009-01-04 13:33:20 -08:00
2009-01-06 15:59:00 -08:00
2009-01-09 03:39:43 -05:00
2009-03-30 14:04:53 +11:00
2009-01-07 11:13:22 -08:00
2009-01-07 11:13:11 -08:00
2009-02-04 16:58:41 -08:00
2009-01-06 17:10:04 -08:00
2009-03-10 16:27:48 +09:00
2009-03-26 18:14:15 +01:00
2009-01-15 16:39:41 -08:00
2009-01-31 00:02:54 +05:30
2009-03-13 15:41:19 -07:00
2009-01-08 08:31:12 -08:00
2009-01-08 08:31:12 -08:00
2009-02-14 22:58:35 -08:00
2009-01-31 00:03:40 +05:30
2009-02-10 17:18:17 -08:00
2009-03-24 16:38:26 -07:00
2008-12-29 09:39:53 -05:00
2009-03-24 16:38:26 -07:00
2009-01-06 15:59:12 -08:00
2009-01-04 12:17:39 +01:00
2009-03-13 16:09:12 -07:00
2009-03-26 18:14:14 +01:00
2009-03-31 01:14:44 +04:00
2009-01-07 21:44:20 +01:00
2009-01-07 21:44:20 +01:00
2009-03-26 02:18:35 +01:00
2009-03-26 02:18:37 +01:00
2009-01-15 16:39:41 -08:00
2009-01-05 18:31:12 -08:00
2009-01-31 00:05:59 +05:30
2009-01-10 06:04:33 -08:00
2009-02-26 04:08:14 +01:00
2009-02-26 04:08:14 +01:00
2009-02-26 04:08:14 +01:00
2009-02-26 04:08:14 +01:00
2009-02-26 23:42:11 -08:00
2009-03-30 12:16:38 -07:00
2009-03-30 12:16:38 -07:00
2009-03-30 12:16:39 -07:00
2009-03-30 12:33:01 -07:00
2009-03-30 12:16:39 -07:00
2009-01-15 16:39:37 -08:00
2008-12-30 17:31:25 -08:00
2009-01-06 15:59:28 -08:00
2009-01-06 15:59:07 -08:00
2009-01-04 13:33:20 -08:00
2009-03-19 23:49:41 -07:00
2009-03-27 17:28:43 +01:00
2009-02-16 00:03:10 -08:00
2009-03-28 15:01:37 +11:00
2009-03-26 18:14:15 +01:00
2009-02-18 15:37:53 -08:00
2009-01-02 10:19:43 -08:00
2009-02-20 17:57:50 -08:00
2009-01-02 10:19:42 -08:00
2009-03-07 18:41:38 -08:00
2009-01-29 16:56:32 +09:00
2009-02-27 16:53:50 +09:00
2009-01-31 00:06:33 +05:30
2009-03-28 13:30:43 -07:00
2009-01-27 23:48:59 +02:00
2009-02-20 17:57:48 -08:00
2009-03-24 10:25:21 +02:00
2009-02-05 22:27:57 +01:00
2009-02-01 00:37:22 -08:00
2009-03-26 16:11:41 -07:00
2009-02-15 22:43:33 -08:00
2009-01-31 00:07:00 +05:30
2009-02-10 00:02:54 +01:00
2009-02-09 08:15:39 -08:00
2009-01-05 08:40:14 +10:30
2009-03-26 18:14:14 +01:00
2009-01-27 02:15:45 -05:00
2009-01-14 19:56:50 -08:00
2009-01-08 08:31:10 -08:00
2008-12-28 09:54:52 +01:00
2009-01-31 00:07:31 +05:30
2009-02-11 14:25:36 -08:00
2009-02-01 01:04:33 -08:00
2009-01-31 00:08:18 +05:30
2009-03-15 20:09:55 -07:00
2008-12-30 09:05:12 +10:30
2009-01-01 10:12:25 +10:30
2009-03-26 18:14:14 +01:00
2009-02-15 22:43:32 -08:00
2009-02-18 19:26:33 +01:00
2009-02-18 15:37:53 -08:00
2009-02-22 12:03:56 +08:00
2009-03-26 18:14:14 +01:00
2009-02-25 18:38:15 +01:00
2009-01-11 19:12:49 +01:00
2009-02-03 11:23:12 +11:00
2009-01-02 10:19:36 -08:00
2009-01-02 10:19:40 -08:00
2009-03-26 18:14:21 +01:00
2009-03-02 11:06:49 +01:00
2009-03-24 16:38:24 -07:00
2009-03-24 16:20:34 -07:00
2009-03-24 16:20:36 -07:00
2009-02-27 16:26:21 -08:00
2009-03-26 18:14:14 +01:00
2009-03-30 12:43:40 -03:00
2009-03-30 12:43:15 -03:00
2008-12-30 09:26:04 +10:30
2009-01-31 00:11:25 +05:30
2009-01-31 00:12:44 +05:30
2009-02-04 16:35:13 -08:00
2008-12-30 09:25:58 +10:30
2008-12-30 09:26:03 +10:30
2009-02-24 21:52:45 +01:00
2009-02-05 12:56:48 -08:00
2009-01-07 10:00:16 -08:00
2009-01-29 16:00:05 -05:00
2009-01-26 09:47:56 -08:00
2009-01-06 15:59:09 -08:00
2009-03-26 18:14:14 +01:00
99b7623380