Jiri Slaby acfa747baf
TTY: open/hangup race fixup ...
Like in the "TTY: don't allow reopen when ldisc is changing" patch,
this one fixes a TTY WARNING as described in the option 1) there:
1) __tty_hangup from tty_ldisc_hangup to tty_ldisc_enable. During this
section tty_lock is held. However tty_lock is temporarily dropped in
the middle of the function by tty_ldisc_hangup.
The fix is to introduce a new flag which we set during the unlocked
window and check it in tty_reopen too. The flag is TTY_HUPPING and is
cleared after TTY_HUPPED is set.
While at it, remove duplicate TTY_HUPPED set_bit. The one after
calling ops->hangup seems to be more correct. But anyway, we hold
tty_lock, so there should be no difference.
Also document the function it does that kind of crap.
Nicely reproducible with two forked children:
static void do_work(const char *tty)
{
if (signal(SIGHUP, SIG_IGN) == SIG_ERR) exit(1);
setsid();
while (1) {
int fd = open(tty, O_RDWR|O_NOCTTY);
if (fd < 0) continue;
if (ioctl(fd, TIOCSCTTY)) continue;
if (vhangup()) continue;
close(fd);
}
exit(0);
}
Signed-off-by: Jiri Slaby <jslaby@suse.cz >
Reported-by: <Valdis.Kletnieks@vt.edu >
Reported-by: Kyle McMartin <kyle@mcmartin.ca >
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk >
Cc: stable <stable@kernel.org >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-11-29 14:52:48 -08:00
2010-10-27 19:04:36 -07:00
2010-10-20 15:38:23 -07:00
2010-10-20 15:37:28 -07:00
2010-11-03 10:44:20 -07:00
2010-10-29 00:30:24 +02:00
2010-10-26 17:54:22 -07:00
2010-11-04 12:21:25 +09:00
2010-10-30 08:31:35 -07:00
2010-10-23 11:47:02 -07:00
2010-10-28 22:40:31 +01:00
2010-11-01 07:50:43 -04:00
2010-11-02 17:13:52 -04:00
2010-11-05 14:13:32 +02:00
2010-10-26 14:51:00 -04:00
2010-10-22 10:20:08 -07:00
2010-10-21 20:21:03 -04:00
2010-11-12 07:55:30 -08:00
2010-10-30 08:45:43 -04:00
2010-10-26 16:52:10 -07:00
2010-10-27 18:03:06 -07:00
2010-10-25 04:54:25 -04:00
2010-11-10 14:54:09 +01:00
2010-11-10 14:54:09 +01:00
2010-11-10 14:54:09 +01:00
2010-10-25 21:18:20 -04:00
2010-10-27 18:03:09 -07:00
2010-10-25 08:02:40 -07:00
2010-10-25 08:02:40 -07:00
2010-10-25 08:02:40 -07:00
2010-10-26 17:32:41 -07:00
2010-10-24 14:20:01 -07:00
2010-10-28 10:27:00 -07:00
2010-10-22 10:16:43 -07:00
2010-10-21 14:23:48 -07:00
2010-10-22 15:55:22 +02:00
2010-10-22 17:03:12 -07:00
2010-10-21 14:47:59 +02:00
2010-10-24 22:06:02 +02:00
2010-10-21 01:26:54 -07:00
2010-10-23 09:24:34 +09:00
2010-10-28 17:22:16 -04:00
2010-10-27 18:03:08 -07:00
2010-10-31 06:35:15 -07:00
2010-10-22 10:22:17 -07:00
2010-11-15 13:49:51 +09:00
2010-10-28 17:22:16 -04:00
2010-10-30 14:07:40 -04:00
2010-10-24 22:06:02 +02:00
2010-10-26 16:52:10 -07:00
2010-10-25 14:11:37 -07:00
2010-11-02 08:39:13 -04:00
2010-10-23 22:49:32 +02:00
2010-11-12 07:55:30 -08:00
2010-11-15 22:40:38 +01:00
2010-11-15 22:40:38 +01:00
2010-10-26 17:40:56 -07:00
2010-11-12 12:30:57 -08:00
2010-10-21 16:08:28 +02:00
2010-10-27 18:03:12 -07:00
2010-10-22 10:21:26 -07:00
2010-11-03 11:04:46 -07:00
2010-10-27 18:48:00 -07:00
2010-10-26 16:52:08 -07:00
2010-11-11 13:40:11 +01:00
2010-10-26 15:33:31 -07:00
2010-10-21 16:08:28 +02:00
2010-10-26 10:33:27 +02:00
2010-10-28 11:58:39 +02:00
2010-10-27 21:25:12 -04:00
2010-10-18 19:58:57 +02:00
2010-10-29 14:45:29 -04:00
2010-10-28 17:22:13 -04:00
2010-10-22 15:34:12 -05:00
2010-10-27 18:03:13 -07:00
2010-11-15 13:37:37 -08:00
2010-10-27 18:03:18 -07:00
2010-10-29 13:14:41 -05:00
2010-10-22 10:16:44 -07:00
2010-10-24 12:47:25 -07:00
2010-10-24 10:50:49 +02:00
2010-10-24 10:52:19 +02:00
2010-11-12 07:55:32 -08:00
2010-11-12 07:55:32 -08:00
2010-11-12 07:55:32 -08:00
2010-10-21 21:18:54 -04:00
2010-10-25 14:11:39 -07:00
2010-10-25 21:24:15 -04:00
2010-10-21 14:11:46 -07:00
2010-10-28 09:08:47 -05:00
2010-10-29 13:50:25 -07:00
2010-10-26 16:52:19 -07:00
2010-10-26 16:52:06 -07:00
2010-10-22 10:16:44 -07:00
2010-10-26 16:52:05 -07:00
2010-10-26 16:52:09 -07:00
2010-10-28 09:02:15 -07:00
2010-10-26 16:52:07 -07:00
2010-10-26 16:52:13 -07:00
2010-11-08 12:17:07 -08:00
2010-11-12 08:26:06 +01:00
2010-10-26 09:55:25 -07:00
2010-10-24 18:07:10 -04:00
2010-10-26 09:52:09 -07:00
2010-10-24 18:07:10 -04:00
2010-10-23 09:24:39 +09:00
2010-10-21 11:10:10 -06:00
2010-10-21 11:10:10 -06:00
2010-10-21 11:34:55 -06:00
2010-10-25 16:10:15 +02:00
2010-10-26 16:52:05 -07:00
2010-10-26 16:52:09 -07:00
2010-10-31 21:06:59 +01:00
2010-10-27 21:30:13 -04:00
2010-10-27 17:53:25 +02:00
2010-10-22 17:31:36 -07:00
2010-11-10 22:58:39 +01:00
2010-10-24 15:07:11 -07:00
2010-10-22 10:16:42 -07:00
2010-10-27 18:03:18 -07:00
2010-11-15 13:37:37 -08:00
2010-10-27 18:03:10 -07:00
2010-11-12 07:55:33 -08:00
2010-11-12 07:55:32 -08:00
2010-10-29 04:16:31 -04:00
2010-10-27 18:03:18 -07:00
2010-10-26 16:52:16 -07:00
2010-10-25 21:18:20 -04:00
2010-11-12 07:55:30 -08:00
2010-10-20 13:37:56 -04:00
2010-10-27 18:03:16 -07:00
2010-10-27 18:03:16 -07:00
2010-10-27 18:03:16 -07:00
2010-10-26 16:52:09 -07:00
2010-10-30 11:50:37 -07:00
2010-11-15 15:40:01 -08:00
2010-10-22 10:20:06 -07:00
2010-10-21 10:12:48 +11:00
2010-10-30 12:12:50 +02:00
2010-10-22 10:20:10 -07:00
2010-10-25 13:46:56 -07:00
2010-10-18 23:57:06 -04:00
2010-11-08 09:35:26 +09:00
2010-11-09 16:38:20 +09:00
2010-10-31 10:40:39 -04:00
2010-10-20 03:02:23 -07:00
2010-10-21 15:44:13 +02:00
2010-10-27 17:28:36 +01:00
2010-10-28 11:47:52 -07:00
2010-10-26 16:52:05 -07:00
2010-10-27 18:03:14 -07:00
2010-10-27 18:03:10 -07:00
2010-10-21 04:11:07 -07:00
2010-10-27 18:03:12 -07:00
2010-10-22 10:20:04 -07:00
2010-11-29 14:52:48 -08:00
2010-10-26 16:52:03 -07:00
2010-10-22 10:16:43 -07:00
2010-10-22 10:22:05 -07:00
2010-11-08 12:28:32 -08:00
2010-10-21 13:45:28 -02:00
2010-10-21 07:55:58 -02:00
2010-10-27 18:03:18 -07:00
2010-10-26 16:52:10 -07:00
2010-10-26 16:52:14 -07:00
2010-10-30 09:05:48 -07:00
acfa747baf