David Howells 8f92054e7c
CRED: Fix __task_cred()'s lockdep check and banner comment ...
Fix __task_cred()'s lockdep check by removing the following validation
condition:
lockdep_tasklist_lock_is_held()
as commit_creds() does not take the tasklist_lock, and nor do most of the
functions that call it, so this check is pointless and it can prevent
detection of the RCU lock not being held if the tasklist_lock is held.
Instead, add the following validation condition:
task->exit_state >= 0
to permit the access if the target task is dead and therefore unable to change
its own credentials.
Fix __task_cred()'s comment to:
(1) discard the bit that says that the caller must prevent the target task
from being deleted. That shouldn't need saying.
(2) Add a comment indicating the result of __task_cred() should not be passed
directly to get_cred(), but rather than get_task_cred() should be used
instead.
Also put a note into the documentation to enforce this point there too.
Signed-off-by: David Howells <dhowells@redhat.com >
Acked-by: Jiri Olsa <jolsa@redhat.com >
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2010-07-29 15:16:18 -07:00
2010-05-30 09:12:43 -07:00
2010-05-26 08:30:15 -07:00
2010-04-28 12:55:14 -07:00
2010-05-17 22:39:48 -07:00
2010-03-12 15:52:44 -08:00
2010-05-19 12:57:48 -03:00
2010-05-27 11:34:55 -07:00
2010-05-28 01:37:38 +02:00
2010-05-28 01:38:00 +02:00
2010-04-21 16:37:49 -07:00
2010-05-31 13:11:47 +09:00
2010-05-14 01:56:12 +01:00
2010-05-31 16:41:35 +02:00
2010-05-03 08:33:00 -04:00
2010-07-28 15:09:26 +01:00
2010-05-25 00:38:26 -06:00
2010-04-26 13:51:09 -04:00
2010-05-14 15:09:37 -04:00
2010-05-31 18:17:22 +02:00
2010-03-30 22:02:32 +09:00
2010-03-12 15:53:10 -08:00
2010-07-24 23:26:09 -04:00
2010-06-15 09:56:01 +10:00
2010-05-14 17:08:01 -04:00
2010-05-27 09:12:53 -07:00
2010-05-21 09:34:30 -07:00
2010-05-21 09:34:30 -07:00
2010-05-19 13:38:54 -04:00
2010-07-06 08:59:53 +02:00
2010-03-16 19:47:54 +00:00
2010-05-30 09:00:03 -07:00
2010-05-18 09:17:01 -07:00
2010-06-01 12:23:18 +02:00
2010-05-27 22:15:33 -04:00
2010-06-08 18:44:04 +02:00
2010-03-24 16:31:22 -07:00
2010-05-10 14:24:26 +02:00
2010-04-28 09:20:33 +02:00
2010-05-25 08:07:00 -07:00
2010-05-27 09:12:53 -07:00
2010-06-29 15:29:31 -07:00
2010-06-29 15:29:31 -07:00
2010-05-29 09:12:30 -07:00
2010-03-12 15:52:32 -08:00
2010-05-19 22:41:05 -04:00
2010-04-09 14:07:56 -07:00
2010-05-27 21:06:58 -04:00
2010-05-27 09:12:44 -07:00
2010-07-29 15:16:18 -07:00
2010-05-19 22:03:14 +03:00
2010-05-15 07:16:33 -04:00
2010-04-22 18:32:12 -07:00
2010-05-19 22:41:57 -04:00
2010-05-10 16:08:01 -07:00
2010-03-30 22:02:32 +09:00
2010-05-22 00:36:56 -06:00
2010-05-27 09:12:53 -07:00
2010-05-17 16:30:58 -07:00
2010-05-21 19:30:44 +02:00
2010-05-18 01:25:00 +02:00
2010-05-18 01:25:00 +02:00
2010-06-14 12:19:41 +02:00
2010-04-26 22:03:42 +04:00
2010-07-04 20:17:22 -07:00
2010-05-10 11:44:49 -03:00
2010-04-09 08:36:07 +02:00
2010-05-17 10:00:15 +02:00
2010-05-21 20:29:10 -07:00
2010-05-25 08:07:02 -07:00
2010-06-29 01:00:29 -07:00
2010-05-21 19:30:39 +02:00
2010-03-29 14:30:19 -07:00
2010-05-27 22:05:02 -04:00
2010-07-20 15:24:09 +10:00
2010-05-21 21:12:40 +02:00
2010-07-20 16:25:41 -07:00
2010-05-24 00:36:13 -07:00
2010-04-26 16:13:54 +02:00
2010-05-27 22:03:07 -04:00
2010-04-22 16:05:44 -07:00
2010-04-15 22:18:36 +02:00
2010-04-15 22:18:36 +02:00
2010-05-19 00:26:30 +02:00
2010-05-21 09:37:28 -07:00
2010-03-26 23:51:44 +01:00
2010-07-06 17:32:07 -07:00
2010-03-29 09:14:47 -07:00
2010-03-30 22:02:32 +09:00
2010-05-27 15:23:47 -07:00
2010-05-18 08:35:04 -07:00
2010-05-25 15:06:06 +02:00
2010-03-30 22:02:32 +09:00
2010-05-21 18:31:18 -04:00
2010-04-03 14:56:05 -07:00
2010-03-16 08:55:32 +01:00
2010-05-25 08:07:01 -07:00
2010-05-27 09:12:42 -07:00
2010-05-21 09:34:29 -07:00
2010-05-19 14:05:06 +02:00
2010-05-25 08:07:01 -07:00
2010-04-06 21:50:03 +02:00
2010-05-01 04:32:14 +02:00
2010-03-13 20:56:56 +01:00
2010-05-20 00:18:59 +01:00
2010-03-14 11:14:58 -07:00
2010-05-22 00:36:56 -06:00
2010-03-24 08:20:03 +01:00
2010-06-30 01:21:38 -07:00
2010-05-24 08:05:29 -07:00
2010-04-20 11:52:21 -04:00
2010-03-30 19:08:43 -07:00
2010-03-30 19:08:43 -07:00
2010-05-17 22:49:55 -07:00
2010-07-22 13:08:56 -07:00
2010-04-13 01:30:48 -07:00
2010-04-03 14:56:04 -07:00
2010-04-03 14:56:04 -07:00
2010-05-03 12:33:13 +03:00
2010-03-21 21:19:02 -07:00
2010-04-22 16:12:36 -07:00
2010-05-06 00:47:21 -07:00
2010-04-23 23:35:28 -07:00
2010-06-01 08:55:52 -07:00
2010-05-20 23:05:28 -07:00
2010-05-21 10:48:12 -07:00
2010-03-30 22:02:32 +09:00
2010-05-24 09:06:59 +02:00
2010-05-11 12:01:10 -07:00
2010-03-12 15:52:40 -08:00
2010-03-12 15:52:40 -08:00
2010-05-11 14:40:55 +02:00
2010-05-03 11:50:57 +02:00
2010-05-19 17:33:38 +09:30
2010-04-01 16:12:48 -07:00
2010-05-25 08:07:09 -07:00
2010-07-15 15:17:47 -07:00
2010-05-21 19:30:40 +02:00
2010-05-20 23:05:28 -07:00
2010-04-22 16:12:36 -07:00
2010-05-20 21:04:27 -05:00
2010-05-25 08:07:05 -07:00
2010-04-23 02:08:44 +02:00
2010-05-20 21:04:29 -05:00
2010-05-27 09:12:45 -07:00
2010-03-15 15:29:39 +01:00
2010-05-21 09:37:32 -07:00
2010-05-21 09:37:29 -07:00
2010-04-21 16:33:29 -07:00
2010-05-14 15:09:32 -04:00
2010-05-19 11:36:29 +03:00
2010-05-17 12:17:10 +03:00
2010-04-03 14:56:05 -07:00
2010-05-26 17:34:16 +01:00
2010-03-15 12:47:59 +01:00
2010-05-26 13:07:55 +01:00
2010-06-02 13:50:10 -04:00
2010-05-25 08:07:07 -07:00
2010-06-29 10:38:22 -07:00
2010-05-21 09:37:30 -07:00
2010-04-28 08:51:12 +10:00
2010-05-25 08:07:09 -07:00
2010-07-14 17:14:00 +10:00
2010-05-27 09:12:44 -07:00
2010-05-25 08:07:00 -07:00
2010-03-17 18:43:47 -07:00
2010-05-25 08:06:57 -07:00
2010-05-18 00:52:36 -03:00
2010-05-25 08:06:59 -07:00
2010-06-09 08:50:31 -07:00
2010-03-12 15:52:28 -08:00
2010-07-19 14:56:17 +10:00
2010-05-27 09:12:57 -07:00
2010-05-21 17:15:44 -07:00
2010-06-05 11:17:36 +09:30
2010-05-11 14:40:55 +02:00
2010-04-13 14:49:34 -07:00
2010-04-28 15:16:48 -07:00
2010-06-30 13:01:11 -07:00
2010-04-22 12:31:11 +02:00
2010-05-17 05:27:42 +02:00
2010-07-02 21:59:08 -07:00
2010-07-05 20:08:05 -07:00
2010-04-20 16:22:01 +02:00
2010-03-25 11:17:26 +01:00
2010-05-21 09:37:32 -07:00
2010-05-06 01:31:27 -07:00
2010-05-14 15:09:30 -04:00
2010-05-14 15:09:21 -04:00
2010-05-14 15:09:30 -04:00
2010-05-10 11:32:33 +09:00
2010-05-07 14:55:50 -04:00
2010-05-30 09:00:03 -07:00
2010-05-27 09:12:47 -07:00
2010-05-22 00:10:41 -06:00
2010-04-28 18:20:29 -06:00
2010-05-22 00:10:40 -06:00
2010-03-18 07:30:31 -06:00
2010-05-19 13:44:27 +10:00
2010-05-27 09:12:44 -07:00
2010-07-01 15:34:46 -04:00
2010-05-21 18:58:52 -07:00
2010-03-12 15:52:42 -08:00
2010-07-16 11:39:48 -07:00
2010-04-16 19:14:34 +04:00
2010-06-01 08:55:52 -07:00
2010-04-05 09:39:11 -07:00
2010-05-31 08:46:09 +02:00
2010-06-04 15:21:45 -07:00
2010-04-02 14:30:39 -07:00
2010-06-03 14:54:39 +02:00
2010-05-17 21:37:40 +02:00
2010-05-10 23:08:19 +02:00
2010-05-10 23:09:30 +02:00
2010-05-10 23:08:15 +02:00
2010-04-24 11:31:25 -07:00
2010-03-12 15:53:11 -08:00
2010-05-19 12:14:42 +04:00
2010-04-03 14:56:02 -07:00
2010-03-26 11:33:55 +01:00
2010-05-27 18:56:27 +02:00
2010-05-30 09:11:11 -07:00
2010-04-09 10:12:03 -07:00
2010-05-21 18:31:26 -04:00
2010-05-27 09:12:52 -07:00
2010-05-25 08:07:03 -07:00
2010-07-05 14:43:50 +02:00
2010-05-03 15:53:54 -07:00
2010-05-10 16:53:55 -07:00
2010-05-18 08:27:54 -07:00
2010-05-18 08:27:54 -07:00
2010-03-12 15:52:44 -08:00
2010-05-21 18:31:19 -04:00
2010-05-21 18:31:19 -04:00
2010-04-27 13:06:35 -04:00
2010-05-27 09:12:50 -07:00
2010-05-27 09:12:50 -07:00
2010-05-27 09:12:51 -07:00
2010-05-30 09:02:47 -07:00
2010-05-25 08:06:58 -07:00
2010-05-11 10:09:47 +02:00
2010-03-12 15:52:28 -08:00
2010-03-12 15:53:10 -08:00
2010-05-11 14:40:55 +02:00
2010-03-13 01:21:21 +01:00
2010-07-29 15:16:18 -07:00
2010-05-27 09:12:39 -07:00
2010-05-06 10:56:07 +10:00
2010-05-27 09:12:49 -07:00
2010-05-21 11:08:05 -07:00
2010-05-25 12:22:33 +09:00
2010-04-13 23:27:41 -07:00
2010-05-25 11:41:43 -04:00
2010-05-13 18:42:25 +09:00
2010-04-26 15:50:50 +09:00
2010-04-15 13:13:52 +09:00
2010-03-12 15:52:44 -08:00
2010-06-10 22:23:34 -07:00
2010-05-19 22:03:13 +03:00
2010-04-09 10:09:50 -07:00
2010-05-19 22:03:13 +03:00
2010-05-30 13:02:08 +03:00
2010-04-22 12:37:07 +02:00
2010-04-03 15:09:04 -07:00
2010-04-06 23:53:30 -07:00
2010-06-01 08:55:52 -07:00
2010-05-21 21:12:40 +02:00
2010-05-10 11:08:35 -07:00
2010-04-14 04:49:51 -07:00
2010-05-08 17:12:33 +02:00
2010-06-10 11:02:34 -04:00
2010-05-27 09:12:43 -07:00
2010-05-27 09:12:52 -07:00
2010-07-09 15:53:04 -04:00
2010-05-15 23:28:39 -07:00
2010-05-21 09:37:31 -07:00
2010-07-21 19:27:07 -05:00
2010-03-30 22:02:32 +09:00
2010-05-19 11:36:34 +03:00
2010-05-03 23:50:42 -07:00
2010-05-27 09:12:51 -07:00
2010-05-09 19:35:27 +02:00
2010-03-25 17:18:43 -07:00
2010-04-13 12:43:42 +02:00
2010-04-06 21:50:02 +02:00
2010-03-23 17:19:38 +01:00
2010-05-12 23:02:23 -07:00
2010-05-12 23:02:23 -07:00
2010-05-27 09:12:57 -07:00
2010-06-21 12:23:36 -04:00
2010-03-12 15:52:43 -08:00
2010-05-21 09:34:29 -07:00
2010-05-17 07:57:27 -07:00
2010-05-20 23:05:28 -07:00
2010-05-20 13:21:50 -07:00
2010-05-19 22:40:47 -04:00
2010-07-21 09:51:15 +10:00
2010-05-11 16:07:59 -06:00
2010-05-11 16:07:59 -06:00
2010-05-11 16:07:59 -06:00
2010-05-19 12:58:37 -03:00
2010-03-13 08:57:28 -06:00
2010-05-19 22:15:40 +09:30
2010-05-19 22:15:49 +09:30
2010-05-19 22:15:46 +09:30
2010-05-25 08:06:59 -07:00
2010-03-19 07:17:52 -07:00
2010-05-20 21:26:12 -07:00
2010-03-23 16:50:26 -04:00
2010-07-06 08:54:08 +02:00
2010-05-21 18:31:18 -04:00
2010-04-06 20:35:58 +04:00
2010-05-17 21:37:42 +02:00
8f92054e7c