TononixOS/ubports_kernel_google_msm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qseecom: Remove mutex lock in load_fw API

Browse Source 
Loading of app is stuck waiting for lock on app_access_lock
being released.  This mutex is already locked prior to invoking
load_fw.
Removing the mutex lock (already called before invoking load_fw),
in load_fw, fixes the issue with the loading getting stuck.

Change-Id: Ia095bf268c6c1c08dfe1544280567ba4bd4661d6
Signed-off-by: Mona Hossain <mhossain@codeaurora.org>
This commit is contained in:
Mona Hossain
2012-11-13 14:01:01 -08:00
committed by Iliyan Malchev
parent 4a226f77f3
commit 9e2fc64f49
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/misc/qseecom.c
View File

@@ -1318,12 +1318,10 @@ static int __qseecom_load_fw(struct qseecom_dev_handle *data, char *appname)
/* Populate the remaining parameters */
load_req.qsee_cmd_id = QSEOS_APP_START_COMMAND;
memcpy(load_req.app_name, appname, MAX_APP_NAME_SIZE);
mutex_lock(&app_access_lock);
ret = qsee_vote_for_clock(CLK_SFPB);
if (ret) {
kzfree(img_data);
pr_warning("Unable to vote for SFPB clock");
mutex_unlock(&app_access_lock);
return -EIO;
}
@@ -1335,7 +1333,6 @@ static int __qseecom_load_fw(struct qseecom_dev_handle *data, char *appname)
if (ret) {
pr_err("scm_call to load failed : ret %d\n", ret);
qsee_disable_clock_vote(CLK_SFPB);
mutex_unlock(&app_access_lock);
return -EIO;
}
@@ -1359,7 +1356,6 @@ static int __qseecom_load_fw(struct qseecom_dev_handle *data, char *appname)
break;
}
qsee_disable_clock_vote(CLK_SFPB);
mutex_unlock(&app_access_lock);
return ret;
}